[oe,meta-oe,1/3] libhugetlbfs: Add ix86 to list of compatible host architectures

Message ID 1416869955-13519-2-git-send-email-gary.robertson@linaro.org
State New
Headers show

Commit Message

gary.robertson@linaro.org Nov. 24, 2014, 10:59 p.m.
From: "Gary S. Robertson" <gary.robertson@linaro.org>

COMPATIBLE_HOST included support for x86_64 but not for
32-bit x86 architectures - added generic 32-bit x86 arch names

Upstream Status - not applicable - recipe change only

Signed-off-by: Gary S. Robertson <gary.robertson@linaro.org>
---
 .../libhugetlbfs/libhugetlbfs_git.bb               |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

gary.robertson@linaro.org Dec. 19, 2014, 9:29 p.m. | #1
I am wondering if this patch was overlooked, as I have seen no commentary
regarding it, and the two other patches which accompanied it have been
merged into the meta-oe libhugetlbfs recipe already.
I added explicit arch designators for the typically-used 32-bit intel
architectures so the recipe could be built for those platforms and not just
for 64-bit intel platforms.

Thanks & have a happy holiday season!

Gary Robertson

On Mon, Nov 24, 2014 at 4:59 PM, Gary S. Robertson <
gary.robertson@linaro.org> wrote:
>
> From: "Gary S. Robertson" <gary.robertson@linaro.org>
>
> COMPATIBLE_HOST included support for x86_64 but not for
> 32-bit x86 architectures - added generic 32-bit x86 arch names
>
> Upstream Status - not applicable - recipe change only
>
> Signed-off-by: Gary S. Robertson <gary.robertson@linaro.org>
> ---
>  .../libhugetlbfs/libhugetlbfs_git.bb               |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> index c2262ea..737acb9 100644
> --- a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> +++ b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> @@ -23,7 +23,7 @@ SRC_URI = "git://git.code.sf.net/p/libhugetlbfs/code \
>
>  S = "${WORKDIR}/git"
>
> -COMPATIBLE_HOST = "(x86_64|powerpc|powerpc64|aarch64|arm).*-linux*"
> +COMPATIBLE_HOST =
> "(i386|i486|i586|i686|x86_64|powerpc|powerpc64|aarch64|arm).*-linux*"
>
>  LIBARGS = "LIB32=${baselib} LIB64=${baselib}"
>  LIBHUGETLBFS_ARCH = "${TARGET_ARCH}"
> --
> 1.7.9.5
>
>
gary.robertson@linaro.org Dec. 20, 2014, 5:56 a.m. | #2
Hmm...  Perhaps I goofed with the way I submitted the patches -
I'm afraid I'm a relative noob at patch submission, and still learning best
practices.

The recipe won't build for qemux86 without also applying the Makefile patch
in
'[meta-oe][PATCH 2/3] libhugetlbfs: Make cross-devel recognize all ix86
arches'
(BTW, that Makefile patch has now also been merged into libhugetlbfs.)

So if the patches were applied and tested separately in numerical sequence,
I would expect the qemux86 build to fail with only the first patch applied.

However, I generated these patches specifically to enable me to build
libhugetlbfs for qemux86, and with both patches in place I have been
building successfully for both i586 (qemux86) and x86_64 intel
architectures.

Just for confirmation I rebuilt tonight for qemux86, and had no problems.
So could I ask you to give this patch another try with the other patches
already in place?

Thanks again - and thanks also for the fast reply... looking at the OE lists
I know there is lots of activity to be dealt with.

Gay Robertson

On Fri, Dec 19, 2014 at 5:07 PM, Martin Jansa <martin.jansa@gmail.com>
wrote:
>
> I've intentionally skipped it, because it failed to build.
>
> Unfortunately I've reported the issue in reply to different patch which
> wasn't the cause of the error:
>
> http://lists.openembedded.org/pipermail/openembedded-devel/2014-December/099239.html
>
> On Fri, Dec 19, 2014 at 10:29 PM, Gary Robertson <
> gary.robertson@linaro.org>
> wrote:
> >
> > I am wondering if this patch was overlooked, as I have seen no commentary
> > regarding it, and the two other patches which accompanied it have been
> > merged into the meta-oe libhugetlbfs recipe already.
> > I added explicit arch designators for the typically-used 32-bit intel
> > architectures so the recipe could be built for those platforms and not
> just
> > for 64-bit intel platforms.
> >
> > Thanks & have a happy holiday season!
> >
> > Gary Robertson
> >
> > On Mon, Nov 24, 2014 at 4:59 PM, Gary S. Robertson <
> > gary.robertson@linaro.org> wrote:
> > >
> > > From: "Gary S. Robertson" <gary.robertson@linaro.org>
> > >
> > > COMPATIBLE_HOST included support for x86_64 but not for
> > > 32-bit x86 architectures - added generic 32-bit x86 arch names
> > >
> > > Upstream Status - not applicable - recipe change only
> > >
> > > Signed-off-by: Gary S. Robertson <gary.robertson@linaro.org>
> > > ---
> > >  .../libhugetlbfs/libhugetlbfs_git.bb               |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/
> libhugetlbfs_git.bb
> > > b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> > > index c2262ea..737acb9 100644
> > > --- a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> > > +++ b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> > > @@ -23,7 +23,7 @@ SRC_URI = "git://git.code.sf.net/p/libhugetlbfs/code
> \
> > >
> > >  S = "${WORKDIR}/git"
> > >
> > > -COMPATIBLE_HOST = "(x86_64|powerpc|powerpc64|aarch64|arm).*-linux*"
> > > +COMPATIBLE_HOST =
> > > "(i386|i486|i586|i686|x86_64|powerpc|powerpc64|aarch64|arm).*-linux*"
> > >
> > >  LIBARGS = "LIB32=${baselib} LIB64=${baselib}"
> > >  LIBHUGETLBFS_ARCH = "${TARGET_ARCH}"
> > > --
> > > 1.7.9.5
> > >
> > >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
index c2262ea..737acb9 100644
--- a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
+++ b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
@@ -23,7 +23,7 @@  SRC_URI = "git://git.code.sf.net/p/libhugetlbfs/code \
 
 S = "${WORKDIR}/git"
 
-COMPATIBLE_HOST = "(x86_64|powerpc|powerpc64|aarch64|arm).*-linux*"
+COMPATIBLE_HOST = "(i386|i486|i586|i686|x86_64|powerpc|powerpc64|aarch64|arm).*-linux*"
 
 LIBARGS = "LIB32=${baselib} LIB64=${baselib}"
 LIBHUGETLBFS_ARCH = "${TARGET_ARCH}"