[V2,08/18] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work

Message ID 20210406113306.2633595-9-xiaoning.wang@nxp.com
State New
Headers show
Series
  • i2c: imx-lpi2c: New features and bug fixes
Related show

Commit Message

Clark Wang April 6, 2021, 11:32 a.m.
From: Gao Pan <pandy.gao@nxp.com>

add debug message when i2c peripheral clk rate is 0, then
directly return -EINVAL.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Signed-off-by: Gao Pan <pandy.gao@nxp.com>
Reviewed-by: Andy Duan <fugang.duan@nxp.com>
---
V2 changes:
 - Add my signed-off.
---
 drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Aisheng Dong May 21, 2021, 6:43 a.m. | #1
> From: Clark Wang <xiaoning.wang@nxp.com>

> Sent: Tuesday, April 6, 2021 7:33 PM

> 

> add debug message when i2c peripheral clk rate is 0, then directly return

> -EINVAL.

> 

> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>


You sign-off should be put after the original patch author

> Signed-off-by: Gao Pan <pandy.gao@nxp.com>

> Reviewed-by: Andy Duan <fugang.duan@nxp.com>


Drop the original review when they're significant changes

> ---

> V2 changes:

>  - Add my signed-off.

> ---

>  drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++

>  1 file changed, 5 insertions(+)

> 

> diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c

> b/drivers/i2c/busses/i2c-imx-lpi2c.c

> index 333209ba81c1..dfec334712c2 100644

> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c

> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c

> @@ -210,6 +210,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct

> *lpi2c_imx)

>  	lpi2c_imx_set_mode(lpi2c_imx);

> 

>  	clk_rate = clk_get_rate(lpi2c_imx->clk_per);

> +	if (!clk_rate) {

> +		dev_dbg(&lpi2c_imx->adapter.dev, "clk_per rate is 0\n");


s/dev_dbg/dev_err

> +		return -EINVAL;

> +	}

> +

>  	if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)

>  		filt = 0;

>  	else

> --

> 2.25.1

Patch

diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index 333209ba81c1..dfec334712c2 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -210,6 +210,11 @@  static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx)
 	lpi2c_imx_set_mode(lpi2c_imx);
 
 	clk_rate = clk_get_rate(lpi2c_imx->clk_per);
+	if (!clk_rate) {
+		dev_dbg(&lpi2c_imx->adapter.dev, "clk_per rate is 0\n");
+		return -EINVAL;
+	}
+
 	if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
 		filt = 0;
 	else