[RESEND,v1,1/5] efi_loader: Kconfig: Select IMAGE_SIGN_INFO when capsule authentication is enabled

Message ID 20210407144147.29251-2-sughosh.ganu@linaro.org
State Accepted
Commit dd40cf6f1fa4a6828de19c3479934ed7409af303
Headers show
Series
  • Add support for embedding public key in platform's dtb
Related show

Commit Message

Sughosh Ganu April 7, 2021, 2:41 p.m.
Enable building of the crypto helper functions used during capsule
authentication by selecting IMAGE_SIGN_INFO.

Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>

---

This was not detected when support for capsule auth was added to the
qemu arm64 platform. This is because the platform includes
CONFIG_FIT_SIGNATURE which selects IMAGE_SIGN_INFO.


 lib/efi_loader/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

Comments

Simon Glass April 7, 2021, 4:14 p.m. | #1
On Thu, 8 Apr 2021 at 02:42, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>

> Enable building of the crypto helper functions used during capsule

> authentication by selecting IMAGE_SIGN_INFO.

>

> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>

> ---

>

> This was not detected when support for capsule auth was added to the

> qemu arm64 platform. This is because the platform includes

> CONFIG_FIT_SIGNATURE which selects IMAGE_SIGN_INFO.

>

>

>  lib/efi_loader/Kconfig | 1 +

>  1 file changed, 1 insertion(+)


Reviewed-by: Simon Glass <sjg@chromium.org>

Patch

diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
index e44f004f3f..0b99d7c774 100644
--- a/lib/efi_loader/Kconfig
+++ b/lib/efi_loader/Kconfig
@@ -173,6 +173,7 @@  config EFI_CAPSULE_AUTHENTICATE
 	select X509_CERTIFICATE_PARSER
 	select PKCS7_MESSAGE_PARSER
 	select PKCS7_VERIFY
+	select IMAGE_SIGN_INFO
 	default n
 	help
 	  Select this option if you want to enable capsule