[4/8,v3] Input: cyttsp - Error message on boot mode exit error

Message ID 20210408131153.3446138-5-linus.walleij@linaro.org
State Accepted
Commit 39841136766651e487458d9ee1660fe86aa697f3
Headers show
Series
  • Update CYTTSP driver
Related show

Commit Message

Linus Walleij April 8, 2021, 1:11 p.m.
Provide a proper error message when attempting to exit
boot loader mode and failing, which is something that
happened to me.

Reviewed-by: Javier Martinez Canillas <javier@dowhile0.org>

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
ChangeLog v1->v3:
- Collect Javier's Reviewed-by
---
 drivers/input/touchscreen/cyttsp_core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.29.2

Comments

Dmitry Torokhov April 10, 2021, 7:31 a.m. | #1
On Thu, Apr 08, 2021 at 03:11:49PM +0200, Linus Walleij wrote:
> Provide a proper error message when attempting to exit

> boot loader mode and failing, which is something that

> happened to me.

> 

> Reviewed-by: Javier Martinez Canillas <javier@dowhile0.org>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


Applied, thank you.

-- 
Dmitry

Patch

diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
index a19d7cce95ca..91f8f38b3f06 100644
--- a/drivers/input/touchscreen/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp_core.c
@@ -410,8 +410,10 @@  static int cyttsp_power_on(struct cyttsp *ts)
 	if (GET_BOOTLOADERMODE(ts->bl_data.bl_status) &&
 	    IS_VALID_APP(ts->bl_data.bl_status)) {
 		error = cyttsp_exit_bl_mode(ts);
-		if (error)
+		if (error) {
+			dev_err(ts->dev, "failed to exit bootloader mode\n");
 			return error;
+		}
 	}
 
 	if (GET_HSTMODE(ts->bl_data.bl_file) != CY_OPERATE_MODE ||