| Message ID | 20210407150157.801210-5-dmitry.baryshkov@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/msm/dpu: always use mdp device to scale bandwidth | expand |
On Wed 07 Apr 10:01 CDT 2021, Dmitry Baryshkov wrote: > Move the bus clock to mdp device node,in order to facilitate bus band > width scaling on sm8250 target. > > The parent device MDSS will not vote for bus bw, instead the vote will > be triggered by mdp device node. Since a minimum vote is required to > turn on bus clock, move the clock node to mdp device from where the > votes are requested. > This commit message makes sense for the other commit, where you move the "bus" into the mdp. Do you mind me changing this to: The bus clock is voted by the DPU, so remove it from the MDSS node. Regards, Bjorn > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 394973e778f7..60fe2eaf06c5 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -2294,10 +2294,9 @@ mdss: mdss@ae00000 { > power-domains = <&dispcc MDSS_GDSC>; > > clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, > - <&gcc GCC_DISP_HF_AXI_CLK>, > <&gcc GCC_DISP_SF_AXI_CLK>, > <&dispcc DISP_CC_MDSS_MDP_CLK>; > - clock-names = "iface", "bus", "nrt_bus", "core"; > + clock-names = "iface", "nrt_bus", "core"; > > assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>; > assigned-clock-rates = <460000000>; > -- > 2.30.2 >
On Mon, 31 May 2021 at 17:58, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Wed 07 Apr 10:01 CDT 2021, Dmitry Baryshkov wrote: > > > Move the bus clock to mdp device node,in order to facilitate bus band > > width scaling on sm8250 target. > > > > The parent device MDSS will not vote for bus bw, instead the vote will > > be triggered by mdp device node. Since a minimum vote is required to > > turn on bus clock, move the clock node to mdp device from where the > > votes are requested. > > > > This commit message makes sense for the other commit, where you move the > "bus" into the mdp. Do you mind me changing this to: > > The bus clock is voted by the DPU, so remove it from the MDSS node. I don't mind, please update the commit message as you see fit. > > Regards, > Bjorn > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > > index 394973e778f7..60fe2eaf06c5 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > > @@ -2294,10 +2294,9 @@ mdss: mdss@ae00000 { > > power-domains = <&dispcc MDSS_GDSC>; > > > > clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, > > - <&gcc GCC_DISP_HF_AXI_CLK>, > > <&gcc GCC_DISP_SF_AXI_CLK>, > > <&dispcc DISP_CC_MDSS_MDP_CLK>; > > - clock-names = "iface", "bus", "nrt_bus", "core"; > > + clock-names = "iface", "nrt_bus", "core"; > > > > assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>; > > assigned-clock-rates = <460000000>; > > -- > > 2.30.2 > >
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index 394973e778f7..60fe2eaf06c5 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -2294,10 +2294,9 @@ mdss: mdss@ae00000 { power-domains = <&dispcc MDSS_GDSC>; clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, - <&gcc GCC_DISP_HF_AXI_CLK>, <&gcc GCC_DISP_SF_AXI_CLK>, <&dispcc DISP_CC_MDSS_MDP_CLK>; - clock-names = "iface", "bus", "nrt_bus", "core"; + clock-names = "iface", "nrt_bus", "core"; assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>; assigned-clock-rates = <460000000>;
Move the bus clock to mdp device node,in order to facilitate bus band width scaling on sm8250 target. The parent device MDSS will not vote for bus bw, instead the vote will be triggered by mdp device node. Since a minimum vote is required to turn on bus clock, move the clock node to mdp device from where the votes are requested. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)