diff mbox series

[next] media: venus: core,pm: fix potential infinite loop

Message ID 20210407134831.494351-1-colin.king@canonical.com
State Accepted
Commit 999267d07240f0a9d8a85c0521b311331081b605
Headers show
Series [next] media: venus: core,pm: fix potential infinite loop | expand

Commit Message

Colin King April 7, 2021, 1:48 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The for-loop iterates with a u8 loop counter i and compares this
with the loop upper limit of res->resets_num which is an unsigned
int type.  There is a potential infinite loop if res->resets_num
is larger than the u8 loop counter i. Fix this by making the loop
counter the same type as res->resets_num.

Addresses-Coverity: ("Infinite loop")
Fixes: 3bca43585e22 ("media: venus: core,pm: Add handling for resets")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/media/platform/qcom/venus/pm_helpers.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

patchwork-bot+linux-arm-msm@kernel.org May 26, 2021, 7:03 p.m. UTC | #1 
Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Wed,  7 Apr 2021 14:48:31 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>

> 

> The for-loop iterates with a u8 loop counter i and compares this

> with the loop upper limit of res->resets_num which is an unsigned

> int type.  There is a potential infinite loop if res->resets_num

> is larger than the u8 loop counter i. Fix this by making the loop

> counter the same type as res->resets_num.

> 

> [...]


Here is the summary with links:
  - [next] media: venus: core,pm: fix potential infinite loop
    https://git.kernel.org/qcom/c/999267d07240

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
index dfe3ee84eeb6..5c0a9aa23e83 100644
--- a/drivers/media/platform/qcom/venus/pm_helpers.c
+++ b/drivers/media/platform/qcom/venus/pm_helpers.c
@@ -868,7 +868,7 @@  static void vcodec_domains_put(struct venus_core *core)
 static int core_resets_reset(struct venus_core *core)
 {
 	const struct venus_resources *res = core->res;
-	unsigned char i;
+	unsigned int i;
 	int ret;
 
 	if (!res->resets_num)
@@ -893,7 +893,7 @@  static int core_resets_get(struct venus_core *core)
 {
 	struct device *dev = core->dev;
 	const struct venus_resources *res = core->res;
-	unsigned char i;
+	unsigned int i;
 	int ret;
 
 	if (!res->resets_num)