iommu: exynos: remove unneeded local variable initialization

Message ID 20210408201622.78009-1-krzysztof.kozlowski@canonical.com
State New
Headers show
Series
  • iommu: exynos: remove unneeded local variable initialization
Related show

Commit Message

Krzysztof Kozlowski April 8, 2021, 8:16 p.m.
The initialization of 'fault_addr' local variable is not needed as it is
shortly after overwritten.

Addresses-Coverity: Unused value
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/iommu/exynos-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Szyprowski April 9, 2021, 12:17 p.m. | #1
On 08.04.2021 22:16, Krzysztof Kozlowski wrote:
> The initialization of 'fault_addr' local variable is not needed as it is

> shortly after overwritten.

>

> Addresses-Coverity: Unused value

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>


> ---

>   drivers/iommu/exynos-iommu.c | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c

> index de324b4eedfe..8fa9a591fb96 100644

> --- a/drivers/iommu/exynos-iommu.c

> +++ b/drivers/iommu/exynos-iommu.c

> @@ -407,7 +407,7 @@ static irqreturn_t exynos_sysmmu_irq(int irq, void *dev_id)

>   	struct sysmmu_drvdata *data = dev_id;

>   	const struct sysmmu_fault_info *finfo;

>   	unsigned int i, n, itype;

> -	sysmmu_iova_t fault_addr = -1;

> +	sysmmu_iova_t fault_addr;

>   	unsigned short reg_status, reg_clear;

>   	int ret = -ENOSYS;

>   


Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Joerg Roedel April 15, 2021, 1:36 p.m. | #2
On Thu, Apr 08, 2021 at 10:16:22PM +0200, Krzysztof Kozlowski wrote:
>  drivers/iommu/exynos-iommu.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


Applied, thanks.

Patch

diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index de324b4eedfe..8fa9a591fb96 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -407,7 +407,7 @@  static irqreturn_t exynos_sysmmu_irq(int irq, void *dev_id)
 	struct sysmmu_drvdata *data = dev_id;
 	const struct sysmmu_fault_info *finfo;
 	unsigned int i, n, itype;
-	sysmmu_iova_t fault_addr = -1;
+	sysmmu_iova_t fault_addr;
 	unsigned short reg_status, reg_clear;
 	int ret = -ENOSYS;