gpio: mxs: remove useless function

Message ID 1618193781-35329-1-git-send-email-jiapeng.chong@linux.alibaba.com
State New
Headers show
Series
  • gpio: mxs: remove useless function
Related show

Commit Message

Jiapeng Chong April 12, 2021, 2:16 a.m.
Fix the following gcc warning:

drivers/gpio/gpio-mxs.c:63:19: warning: kernel/sys_ni.cunused function
'is_imx28_gpio'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/gpio/gpio-mxs.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Bartosz Golaszewski April 13, 2021, 10:39 a.m. | #1
On Mon, Apr 12, 2021 at 4:16 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>

> Fix the following gcc warning:

>

> drivers/gpio/gpio-mxs.c:63:19: warning: kernel/sys_ni.cunused function

> 'is_imx28_gpio'.

>

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>

> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

> ---

>  drivers/gpio/gpio-mxs.c | 5 -----

>  1 file changed, 5 deletions(-)

>

> diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c

> index dfc0c1e..524b668 100644

> --- a/drivers/gpio/gpio-mxs.c

> +++ b/drivers/gpio/gpio-mxs.c

> @@ -60,11 +60,6 @@ static inline int is_imx23_gpio(struct mxs_gpio_port *port)

>         return port->devid == IMX23_GPIO;

>  }

>

> -static inline int is_imx28_gpio(struct mxs_gpio_port *port)

> -{

> -       return port->devid == IMX28_GPIO;

> -}

> -

>  /* Note: This driver assumes 32 GPIOs are handled in one register */

>

>  static int mxs_gpio_set_irq_type(struct irq_data *d, unsigned int type)

> --

> 1.8.3.1

>


Patch applied, thanks!

Bartosz

Patch

diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
index dfc0c1e..524b668 100644
--- a/drivers/gpio/gpio-mxs.c
+++ b/drivers/gpio/gpio-mxs.c
@@ -60,11 +60,6 @@  static inline int is_imx23_gpio(struct mxs_gpio_port *port)
 	return port->devid == IMX23_GPIO;
 }
 
-static inline int is_imx28_gpio(struct mxs_gpio_port *port)
-{
-	return port->devid == IMX28_GPIO;
-}
-
 /* Note: This driver assumes 32 GPIOs are handled in one register */
 
 static int mxs_gpio_set_irq_type(struct irq_data *d, unsigned int type)