diff mbox series

[RFC,v2,1/4] PCI: Add vendor define ID for the PCI SIG

Message ID 20210413160159.935663-2-Jonathan.Cameron@huawei.com
State Superseded
Headers show
Series PCI Data Object Exchange support + CXL CDAT | expand

Commit Message

Jonathan Cameron April 13, 2021, 4:01 p.m. UTC
This ID is used in DOE headers to identify protocols that are
defined within the PCI Express Base Specification.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

---
Since V1: New Patch

 include/linux/pci_ids.h | 1 +
 1 file changed, 1 insertion(+)

-- 
2.19.1

Comments

Bjorn Helgaas April 13, 2021, 4:34 p.m. UTC | #1
On Wed, Apr 14, 2021 at 12:01:56AM +0800, Jonathan Cameron wrote:
> This ID is used in DOE headers to identify protocols that are

> defined within the PCI Express Base Specification.


Can you please include the specific spec citation here?

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---

> Since V1: New Patch

> 

>  include/linux/pci_ids.h | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h

> index a76ccb697bef..2c0459c23331 100644

> --- a/include/linux/pci_ids.h

> +++ b/include/linux/pci_ids.h

> @@ -149,6 +149,7 @@

>  #define PCI_CLASS_OTHERS		0xff

>  

>  /* Vendors and devices.  Sort key: vendor first, device next. */

> +#define PCI_VENDOR_ID_PCI_SIG		0x0001

>  

>  #define PCI_VENDOR_ID_LOONGSON		0x0014

>  

> -- 

> 2.19.1

>
Jonathan Cameron April 13, 2021, 6:21 p.m. UTC | #2
On Tue, 13 Apr 2021 11:34:48 -0500
Bjorn Helgaas <helgaas@kernel.org> wrote:

> On Wed, Apr 14, 2021 at 12:01:56AM +0800, Jonathan Cameron wrote:

> > This ID is used in DOE headers to identify protocols that are

> > defined within the PCI Express Base Specification.  

> 

> Can you please include the specific spec citation here?


Will make sure to add to cover leter for next version but for now, 

Table 7-x2: Data Object Exchange ECN
(first column lists the Vendor ID for the protocols)

Available on the PCI SIG spec downloads page.
It also exists in various other places in the 5.0 spec, but I'm
not sure if any are software visible (e.g. VDMs)

Jonathan


> 

> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> > ---

> > Since V1: New Patch

> > 

> >  include/linux/pci_ids.h | 1 +

> >  1 file changed, 1 insertion(+)

> > 

> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h

> > index a76ccb697bef..2c0459c23331 100644

> > --- a/include/linux/pci_ids.h

> > +++ b/include/linux/pci_ids.h

> > @@ -149,6 +149,7 @@

> >  #define PCI_CLASS_OTHERS		0xff

> >  

> >  /* Vendors and devices.  Sort key: vendor first, device next. */

> > +#define PCI_VENDOR_ID_PCI_SIG		0x0001

> >  

> >  #define PCI_VENDOR_ID_LOONGSON		0x0014

> >  

> > -- 

> > 2.19.1

> >
Bjorn Helgaas April 13, 2021, 6:38 p.m. UTC | #3
On Tue, Apr 13, 2021 at 07:21:35PM +0100, Jonathan Cameron wrote:
> On Tue, 13 Apr 2021 11:34:48 -0500

> Bjorn Helgaas <helgaas@kernel.org> wrote:

> 

> > On Wed, Apr 14, 2021 at 12:01:56AM +0800, Jonathan Cameron wrote:

> > > This ID is used in DOE headers to identify protocols that are

> > > defined within the PCI Express Base Specification.  

> > 

> > Can you please include the specific spec citation here?

> 

> Will make sure to add to cover leter for next version but for now, 

> 

> Table 7-x2: Data Object Exchange ECN

> (first column lists the Vendor ID for the protocols)


I wish the SIG would formally define this Vendor ID instead of just
starting to use it, but this is better than nothing.

Please put this in the log for this commit, since the cover letter may
not be merged and isn't directly connected to this commit.

> Available on the PCI SIG spec downloads page.

> It also exists in various other places in the 5.0 spec, but I'm

> not sure if any are software visible (e.g. VDMs)

> 

> Jonathan

> 

> > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> > > ---

> > > Since V1: New Patch

> > > 

> > >  include/linux/pci_ids.h | 1 +

> > >  1 file changed, 1 insertion(+)

> > > 

> > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h

> > > index a76ccb697bef..2c0459c23331 100644

> > > --- a/include/linux/pci_ids.h

> > > +++ b/include/linux/pci_ids.h

> > > @@ -149,6 +149,7 @@

> > >  #define PCI_CLASS_OTHERS		0xff

> > >  

> > >  /* Vendors and devices.  Sort key: vendor first, device next. */

> > > +#define PCI_VENDOR_ID_PCI_SIG		0x0001

> > >  

> > >  #define PCI_VENDOR_ID_LOONGSON		0x0014

> > >  

> > > -- 

> > > 2.19.1

> > >   

>
diff mbox series

Patch

diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index a76ccb697bef..2c0459c23331 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -149,6 +149,7 @@ 
 #define PCI_CLASS_OTHERS		0xff
 
 /* Vendors and devices.  Sort key: vendor first, device next. */
+#define PCI_VENDOR_ID_PCI_SIG		0x0001
 
 #define PCI_VENDOR_ID_LOONGSON		0x0014