[03/12] drm/exynos: Don't set allow_fb_modifiers explicitly

Message ID 20210413094904.3736372-3-daniel.vetter@ffwll.ch
State New
Headers show
Series
  • Untitled series #119715
Related show

Commit Message

Daniel Vetter April 13, 2021, 9:48 a.m.
Since

commit 890880ddfdbe256083170866e49c87618b706ac7
Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Date:   Fri Jan 4 09:56:10 2019 +0100

    drm: Auto-set allow_fb_modifiers when given modifiers at plane init

this is done automatically as part of plane init, if drivers set the
modifier list correctly. Which is the case here.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
---
 drivers/gpu/drm/exynos/exynos_drm_fb.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Inki Dae April 20, 2021, 6:31 a.m. | #1
21. 4. 13. 오후 6:48에 Daniel Vetter 이(가) 쓴 글:
> Since

> 

> commit 890880ddfdbe256083170866e49c87618b706ac7

> Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

> Date:   Fri Jan 4 09:56:10 2019 +0100

> 

>     drm: Auto-set allow_fb_modifiers when given modifiers at plane init

> 

> this is done automatically as part of plane init, if drivers set the

> modifier list correctly. Which is the case here.

> 

> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>


Acked-by: Inki Dae <inki.dae@samsung.com>


Thanks,
Inki Dae

> Cc: Inki Dae <inki.dae@samsung.com>

> Cc: Joonyoung Shim <jy0922.shim@samsung.com>

> Cc: Seung-Woo Kim <sw0312.kim@samsung.com>

> Cc: Kyungmin Park <kyungmin.park@samsung.com>

> Cc: Krzysztof Kozlowski <krzk@kernel.org>

> Cc: linux-arm-kernel@lists.infradead.org

> Cc: linux-samsung-soc@vger.kernel.org

> ---

>  drivers/gpu/drm/exynos/exynos_drm_fb.c | 2 --

>  1 file changed, 2 deletions(-)

> 

> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c

> index 64370b634cca..79fa3649185c 100644

> --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c

> +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c

> @@ -177,7 +177,5 @@ void exynos_drm_mode_config_init(struct drm_device *dev)

>  	dev->mode_config.funcs = &exynos_drm_mode_config_funcs;

>  	dev->mode_config.helper_private = &exynos_drm_mode_config_helpers;

>  

> -	dev->mode_config.allow_fb_modifiers = true;

> -

>  	dev->mode_config.normalize_zpos = true;

>  }

>
Daniel Vetter April 20, 2021, 8:41 a.m. | #2
On Tue, Apr 20, 2021 at 03:31:27PM +0900, Inki Dae wrote:
> 

> 

> 21. 4. 13. 오후 6:48에 Daniel Vetter 이(가) 쓴 글:

> > Since

> > 

> > commit 890880ddfdbe256083170866e49c87618b706ac7

> > Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

> > Date:   Fri Jan 4 09:56:10 2019 +0100

> > 

> >     drm: Auto-set allow_fb_modifiers when given modifiers at plane init

> > 

> > this is done automatically as part of plane init, if drivers set the

> > modifier list correctly. Which is the case here.

> > 

> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

> 

> Acked-by: Inki Dae <inki.dae@samsung.com>


Thanks for taking a look, pushed to drm-misc-next.
-Daniel

> 

> Thanks,

> Inki Dae

> 

> > Cc: Inki Dae <inki.dae@samsung.com>

> > Cc: Joonyoung Shim <jy0922.shim@samsung.com>

> > Cc: Seung-Woo Kim <sw0312.kim@samsung.com>

> > Cc: Kyungmin Park <kyungmin.park@samsung.com>

> > Cc: Krzysztof Kozlowski <krzk@kernel.org>

> > Cc: linux-arm-kernel@lists.infradead.org

> > Cc: linux-samsung-soc@vger.kernel.org

> > ---

> >  drivers/gpu/drm/exynos/exynos_drm_fb.c | 2 --

> >  1 file changed, 2 deletions(-)

> > 

> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c

> > index 64370b634cca..79fa3649185c 100644

> > --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c

> > +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c

> > @@ -177,7 +177,5 @@ void exynos_drm_mode_config_init(struct drm_device *dev)

> >  	dev->mode_config.funcs = &exynos_drm_mode_config_funcs;

> >  	dev->mode_config.helper_private = &exynos_drm_mode_config_helpers;

> >  

> > -	dev->mode_config.allow_fb_modifiers = true;

> > -

> >  	dev->mode_config.normalize_zpos = true;

> >  }

> > 


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c
index 64370b634cca..79fa3649185c 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fb.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c
@@ -177,7 +177,5 @@  void exynos_drm_mode_config_init(struct drm_device *dev)
 	dev->mode_config.funcs = &exynos_drm_mode_config_funcs;
 	dev->mode_config.helper_private = &exynos_drm_mode_config_helpers;
 
-	dev->mode_config.allow_fb_modifiers = true;
-
 	dev->mode_config.normalize_zpos = true;
 }