| Message ID | YHV230jUzxBJxlPS@mwanda |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] ionic: return -EFAULT if copy_to_user() fails | expand |
On 4/13/21 3:47 AM, Dan Carpenter wrote: > The copy_to_user() function returns the number of bytes that it wasn't > able to copy. We want to return -EFAULT to the user. > > Fixes: fee6efce565d ("ionic: add hw timestamp support files") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Shannon Nelson <snelson@pensando.io> > --- > drivers/net/ethernet/pensando/ionic/ionic_phc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_phc.c b/drivers/net/ethernet/pensando/ionic/ionic_phc.c > index 86ae5011ac9b..d7d8d5e81ea0 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_phc.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_phc.c > @@ -225,7 +225,9 @@ int ionic_lif_hwstamp_get(struct ionic_lif *lif, struct ifreq *ifr) > memcpy(&config, &lif->phc->ts_config, sizeof(config)); > mutex_unlock(&lif->phc->config_lock); > > - return copy_to_user(ifr->ifr_data, &config, sizeof(config)); > + if (copy_to_user(ifr->ifr_data, &config, sizeof(config))) > + return -EFAULT; > + return 0; > } > > static u64 ionic_hwstamp_read(struct ionic *ionic,
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_phc.c b/drivers/net/ethernet/pensando/ionic/ionic_phc.c index 86ae5011ac9b..d7d8d5e81ea0 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_phc.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_phc.c @@ -225,7 +225,9 @@ int ionic_lif_hwstamp_get(struct ionic_lif *lif, struct ifreq *ifr) memcpy(&config, &lif->phc->ts_config, sizeof(config)); mutex_unlock(&lif->phc->config_lock); - return copy_to_user(ifr->ifr_data, &config, sizeof(config)); + if (copy_to_user(ifr->ifr_data, &config, sizeof(config))) + return -EFAULT; + return 0; } static u64 ionic_hwstamp_read(struct ionic *ionic,
The copy_to_user() function returns the number of bytes that it wasn't able to copy. We want to return -EFAULT to the user. Fixes: fee6efce565d ("ionic: add hw timestamp support files") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/pensando/ionic/ionic_phc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)