diff mbox series

[18/40] drm/omapdrm/omap_irq: Fix a couple of incorrectly documented functions

Message ID 20210416143725.2769053-19-lee.jones@linaro.org
State New
Headers show
Series Rid W=1 warnings from GPU! | expand

Commit Message

Lee Jones April 16, 2021, 2:37 p.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/omapdrm/omap_irq.c:114: warning: expecting prototype for enable_vblank(). Prototype was for omap_irq_enable_vblank() instead
 drivers/gpu/drm/omapdrm/omap_irq.c:140: warning: expecting prototype for disable_vblank(). Prototype was for omap_irq_disable_vblank() instead

Cc: Tomi Valkeinen <tomba@kernel.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Rob Clark <rob.clark@linaro.org>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/gpu/drm/omapdrm/omap_irq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.27.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

Tomi Valkeinen April 23, 2021, 12:12 p.m. UTC | #1
On 16/04/2021 17:37, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>   drivers/gpu/drm/omapdrm/omap_irq.c:114: warning: expecting prototype for enable_vblank(). Prototype was for omap_irq_enable_vblank() instead

>   drivers/gpu/drm/omapdrm/omap_irq.c:140: warning: expecting prototype for disable_vblank(). Prototype was for omap_irq_disable_vblank() instead

> 

> Cc: Tomi Valkeinen <tomba@kernel.org>

> Cc: David Airlie <airlied@linux.ie>

> Cc: Daniel Vetter <daniel@ffwll.ch>

> Cc: Rob Clark <rob.clark@linaro.org>

> Cc: dri-devel@lists.freedesktop.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> ---

>   drivers/gpu/drm/omapdrm/omap_irq.c | 4 ++--

>   1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c

> index 15148d4b35b57..dff095c864909 100644

> --- a/drivers/gpu/drm/omapdrm/omap_irq.c

> +++ b/drivers/gpu/drm/omapdrm/omap_irq.c

> @@ -99,7 +99,7 @@ int omap_irq_enable_framedone(struct drm_crtc *crtc, bool enable)

>   }

>   

>   /**

> - * enable_vblank - enable vblank interrupt events

> + * omap_irq_enable_vblank - enable vblank interrupt events

>    * @crtc: DRM CRTC

>    *

>    * Enable vblank interrupts for @crtc.  If the device doesn't have

> @@ -129,7 +129,7 @@ int omap_irq_enable_vblank(struct drm_crtc *crtc)

>   }

>   

>   /**

> - * disable_vblank - disable vblank interrupt events

> + * omap_irq_disable_vblank - disable vblank interrupt events

>    * @crtc: DRM CRTC

>    *

>    * Disable vblank interrupts for @crtc.  If the device doesn't have

> 


Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>


  Tomi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c
index 15148d4b35b57..dff095c864909 100644
--- a/drivers/gpu/drm/omapdrm/omap_irq.c
+++ b/drivers/gpu/drm/omapdrm/omap_irq.c
@@ -99,7 +99,7 @@  int omap_irq_enable_framedone(struct drm_crtc *crtc, bool enable)
 }
 
 /**
- * enable_vblank - enable vblank interrupt events
+ * omap_irq_enable_vblank - enable vblank interrupt events
  * @crtc: DRM CRTC
  *
  * Enable vblank interrupts for @crtc.  If the device doesn't have
@@ -129,7 +129,7 @@  int omap_irq_enable_vblank(struct drm_crtc *crtc)
 }
 
 /**
- * disable_vblank - disable vblank interrupt events
+ * omap_irq_disable_vblank - disable vblank interrupt events
  * @crtc: DRM CRTC
  *
  * Disable vblank interrupts for @crtc.  If the device doesn't have