[v3] drm/bridge/sii8620: fix dependency on extcon

Message ID 20210419090124.153560-1-robert.foss@linaro.org
State New
Headers show
Series
  • [v3] drm/bridge/sii8620: fix dependency on extcon
Related show

Commit Message

Robert Foss April 19, 2021, 9:01 a.m.
The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
on EXTCON, which causes issues when sii8620 is built
as a builtin and EXTCON is built as a module.

The symptoms are 'undefined reference' errors caused
by the symbols in EXTCON not being available
to the sii8620 driver.

Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
Signed-off-by: Robert Foss <robert.foss@linaro.org>

Reported-by: kernel test robot <lkp@intel.com>
---

LKP reported issue:
https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/


Changes since v1:
 - Fix typo on comment

Changes since v2:
 - Randy: Changed from `depends` to `select` 


 drivers/gpu/drm/bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.31.0.30.g398dba342d.dirty

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

Randy Dunlap April 19, 2021, 5:10 p.m. | #1
On 4/19/21 2:01 AM, Robert Foss wrote:
> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency

> on EXTCON, which causes issues when sii8620 is built

> as a builtin and EXTCON is built as a module.

> 

> The symptoms are 'undefined reference' errors caused

> by the symbols in EXTCON not being available

> to the sii8620 driver.

> 

> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")

> Signed-off-by: Robert Foss <robert.foss@linaro.org>

> Reported-by: kernel test robot <lkp@intel.com>

> ---

> 

> LKP reported issue:

> https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/

> 

> 

> Changes since v1:

>  - Fix typo on comment

> 

> Changes since v2:

>  - Randy: Changed from `depends` to `select` 


I don't know why my name is on that. I didn't
suggest any change -- I just reported that v2
had a problem.


> 

> 

>  drivers/gpu/drm/bridge/Kconfig | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig

> index 22a467abd3e9..70402da5cc70 100644

> --- a/drivers/gpu/drm/bridge/Kconfig

> +++ b/drivers/gpu/drm/bridge/Kconfig

> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620

>  	tristate "Silicon Image SII8620 HDMI/MHL bridge"

>  	depends on OF

>  	select DRM_KMS_HELPER

> -	imply EXTCON

> +	select EXTCON

>  	depends on RC_CORE || !RC_CORE

>  	help

>  	  Silicon Image SII8620 HDMI/MHL bridge chip driver.



Thanks. Works For Me.

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested


-- 
~Randy

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Robert Foss April 19, 2021, 5:35 p.m. | #2
On Mon, Apr 19, 2021, 19:11 Randy Dunlap <rdunlap@infradead.org> wrote:

> On 4/19/21 2:01 AM, Robert Foss wrote:

> > The DRM_SIL_SII8620 kconfig has a weak `imply` dependency

> > on EXTCON, which causes issues when sii8620 is built

> > as a builtin and EXTCON is built as a module.

> >

> > The symptoms are 'undefined reference' errors caused

> > by the symbols in EXTCON not being available

> > to the sii8620 driver.

> >

> > Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection

> logic to detect MHL")

> > Signed-off-by: Robert Foss <robert.foss@linaro.org>

> > Reported-by: kernel test robot <lkp@intel.com>

> > ---

> >

> > LKP reported issue:

> > https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/

> >

> >

> > Changes since v1:

> >  - Fix typo on comment

> >

> > Changes since v2:

> >  - Randy: Changed from `depends` to `select`

>

> I don't know why my name is on that. I didn't

> suggest any change -- I just reported that v2

> had a problem.

>


Credit where credit is due :)


>

> >

> >

> >  drivers/gpu/drm/bridge/Kconfig | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/drivers/gpu/drm/bridge/Kconfig

> b/drivers/gpu/drm/bridge/Kconfig

> > index 22a467abd3e9..70402da5cc70 100644

> > --- a/drivers/gpu/drm/bridge/Kconfig

> > +++ b/drivers/gpu/drm/bridge/Kconfig

> > @@ -169,7 +169,7 @@ config DRM_SIL_SII8620

> >       tristate "Silicon Image SII8620 HDMI/MHL bridge"

> >       depends on OF

> >       select DRM_KMS_HELPER

> > -     imply EXTCON

> > +     select EXTCON

> >       depends on RC_CORE || !RC_CORE

> >       help

> >         Silicon Image SII8620 HDMI/MHL bridge chip driver.

>

>

> Thanks. Works For Me.

>

> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

>

> --

> ~Randy

>

>
<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 19, 2021, 19:11 Randy Dunlap &lt;<a href="mailto:rdunlap@infradead.org">rdunlap@infradead.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 4/19/21 2:01 AM, Robert Foss wrote:<br>
&gt; The DRM_SIL_SII8620 kconfig has a weak `imply` dependency<br>
&gt; on EXTCON, which causes issues when sii8620 is built<br>
&gt; as a builtin and EXTCON is built as a module.<br>
&gt; <br>
&gt; The symptoms are &#39;undefined reference&#39; errors caused<br>
&gt; by the symbols in EXTCON not being available<br>
&gt; to the sii8620 driver.<br>
&gt; <br>
&gt; Fixes: 688838442147 (&quot;drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL&quot;)<br>
&gt; Signed-off-by: Robert Foss &lt;<a href="mailto:robert.foss@linaro.org" target="_blank" rel="noreferrer">robert.foss@linaro.org</a>&gt;<br>
&gt; Reported-by: kernel test robot &lt;<a href="mailto:lkp@intel.com" target="_blank" rel="noreferrer">lkp@intel.com</a>&gt;<br>
&gt; ---<br>
&gt; <br>
&gt; LKP reported issue:<br>
&gt; <a href="https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/" rel="noreferrer noreferrer" target="_blank">https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/</a><br>
&gt; <br>
&gt; <br>
&gt; Changes since v1:<br>
&gt;  - Fix typo on comment<br>
&gt; <br>
&gt; Changes since v2:<br>
&gt;  - Randy: Changed from `depends` to `select` <br>
<br>
I don&#39;t know why my name is on that. I didn&#39;t<br>
suggest any change -- I just reported that v2<br>
had a problem.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Credit where credit is due :)</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
&gt; <br>
&gt; <br>
&gt;  drivers/gpu/drm/bridge/Kconfig | 2 +-<br>
&gt;  1 file changed, 1 insertion(+), 1 deletion(-)<br>
&gt; <br>
&gt; diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig<br>
&gt; index 22a467abd3e9..70402da5cc70 100644<br>
&gt; --- a/drivers/gpu/drm/bridge/Kconfig<br>
&gt; +++ b/drivers/gpu/drm/bridge/Kconfig<br>
&gt; @@ -169,7 +169,7 @@ config DRM_SIL_SII8620<br>
&gt;       tristate &quot;Silicon Image SII8620 HDMI/MHL bridge&quot;<br>
&gt;       depends on OF<br>
&gt;       select DRM_KMS_HELPER<br>
&gt; -     imply EXTCON<br>
&gt; +     select EXTCON<br>
&gt;       depends on RC_CORE || !RC_CORE<br>
&gt;       help<br>
&gt;         Silicon Image SII8620 HDMI/MHL bridge chip driver.<br>
<br>
<br>
Thanks. Works For Me.<br>
<br>
Acked-by: Randy Dunlap &lt;<a href="mailto:rdunlap@infradead.org" target="_blank" rel="noreferrer">rdunlap@infradead.org</a>&gt; # build-tested<br>

<br>
-- <br>
~Randy<br>
<br>
</blockquote></div></div></div>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Randy Dunlap April 19, 2021, 5:54 p.m. | #3
On 4/19/21 10:10 AM, Randy Dunlap wrote:
> On 4/19/21 2:01 AM, Robert Foss wrote:

>> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency

>> on EXTCON, which causes issues when sii8620 is built

>> as a builtin and EXTCON is built as a module.

>>

>> The symptoms are 'undefined reference' errors caused

>> by the symbols in EXTCON not being available

>> to the sii8620 driver.

>>

>> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")

>> Signed-off-by: Robert Foss <robert.foss@linaro.org>

>> Reported-by: kernel test robot <lkp@intel.com>

>> ---

>>

>> LKP reported issue:

>> https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/

>>

>>

>> Changes since v1:

>>  - Fix typo on comment

>>

>> Changes since v2:

>>  - Randy: Changed from `depends` to `select` 

> 

> I don't know why my name is on that. I didn't

> suggest any change -- I just reported that v2

> had a problem.

> 

> 

>>

>>

>>  drivers/gpu/drm/bridge/Kconfig | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig

>> index 22a467abd3e9..70402da5cc70 100644

>> --- a/drivers/gpu/drm/bridge/Kconfig

>> +++ b/drivers/gpu/drm/bridge/Kconfig

>> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620

>>  	tristate "Silicon Image SII8620 HDMI/MHL bridge"

>>  	depends on OF

>>  	select DRM_KMS_HELPER

>> -	imply EXTCON

>> +	select EXTCON

>>  	depends on RC_CORE || !RC_CORE

>>  	help

>>  	  Silicon Image SII8620 HDMI/MHL bridge chip driver.

> 

> 

> Thanks. Works For Me.

> 

> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested


Actually I can upgrade that to:

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>



ta.
-- 
~Randy

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Randy Dunlap May 15, 2021, 5:34 a.m. | #4
On 4/19/21 10:54 AM, Randy Dunlap wrote:
> On 4/19/21 10:10 AM, Randy Dunlap wrote:

>> On 4/19/21 2:01 AM, Robert Foss wrote:

>>> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency

>>> on EXTCON, which causes issues when sii8620 is built

>>> as a builtin and EXTCON is built as a module.

>>>

>>> The symptoms are 'undefined reference' errors caused

>>> by the symbols in EXTCON not being available

>>> to the sii8620 driver.

>>>

>>> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")

>>> Signed-off-by: Robert Foss <robert.foss@linaro.org>

>>> Reported-by: kernel test robot <lkp@intel.com>

>>> ---

>>>

>>> LKP reported issue:

>>> https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/

>>>

>>>

>>> Changes since v1:

>>>  - Fix typo on comment

>>>

>>> Changes since v2:

>>>  - Randy: Changed from `depends` to `select` 

>>

>> I don't know why my name is on that. I didn't

>> suggest any change -- I just reported that v2

>> had a problem.

>>

>>

>>>

>>>

>>>  drivers/gpu/drm/bridge/Kconfig | 2 +-

>>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>>

>>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig

>>> index 22a467abd3e9..70402da5cc70 100644

>>> --- a/drivers/gpu/drm/bridge/Kconfig

>>> +++ b/drivers/gpu/drm/bridge/Kconfig

>>> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620

>>>  	tristate "Silicon Image SII8620 HDMI/MHL bridge"

>>>  	depends on OF

>>>  	select DRM_KMS_HELPER

>>> -	imply EXTCON

>>> +	select EXTCON

>>>  	depends on RC_CORE || !RC_CORE

>>>  	help

>>>  	  Silicon Image SII8620 HDMI/MHL bridge chip driver.

>>

>>

>> Thanks. Works For Me.

>>

>> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

> 

> Actually I can upgrade that to:

> 

> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>


Hi,
Is anyone merging this patch?

thanks.
-- 
~Randy
Robert Foss May 15, 2021, 12:09 p.m. | #5
Hey Randy,

I missed sending out a notification, but this patch was merged into
drm-misc-next.

https://cgit.freedesktop.org/drm/drm-misc/commit/?id=08319adbdde15ef7cee1970336f63461254baa2a

On Sat, 15 May 2021 at 07:35, Randy Dunlap <rdunlap@infradead.org> wrote:
>

> On 4/19/21 10:54 AM, Randy Dunlap wrote:

> > On 4/19/21 10:10 AM, Randy Dunlap wrote:

> >> On 4/19/21 2:01 AM, Robert Foss wrote:

> >>> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency

> >>> on EXTCON, which causes issues when sii8620 is built

> >>> as a builtin and EXTCON is built as a module.

> >>>

> >>> The symptoms are 'undefined reference' errors caused

> >>> by the symbols in EXTCON not being available

> >>> to the sii8620 driver.

> >>>

> >>> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")

> >>> Signed-off-by: Robert Foss <robert.foss@linaro.org>

> >>> Reported-by: kernel test robot <lkp@intel.com>

> >>> ---

> >>>

> >>> LKP reported issue:

> >>> https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/

> >>>

> >>>

> >>> Changes since v1:

> >>>  - Fix typo on comment

> >>>

> >>> Changes since v2:

> >>>  - Randy: Changed from `depends` to `select`

> >>

> >> I don't know why my name is on that. I didn't

> >> suggest any change -- I just reported that v2

> >> had a problem.

> >>

> >>

> >>>

> >>>

> >>>  drivers/gpu/drm/bridge/Kconfig | 2 +-

> >>>  1 file changed, 1 insertion(+), 1 deletion(-)

> >>>

> >>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig

> >>> index 22a467abd3e9..70402da5cc70 100644

> >>> --- a/drivers/gpu/drm/bridge/Kconfig

> >>> +++ b/drivers/gpu/drm/bridge/Kconfig

> >>> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620

> >>>     tristate "Silicon Image SII8620 HDMI/MHL bridge"

> >>>     depends on OF

> >>>     select DRM_KMS_HELPER

> >>> -   imply EXTCON

> >>> +   select EXTCON

> >>>     depends on RC_CORE || !RC_CORE

> >>>     help

> >>>       Silicon Image SII8620 HDMI/MHL bridge chip driver.

> >>

> >>

> >> Thanks. Works For Me.

> >>

> >> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

> >

> > Actually I can upgrade that to:

> >

> > Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

>

> Hi,

> Is anyone merging this patch?

>

> thanks.

> --

> ~Randy

>
Randy Dunlap May 15, 2021, 3:46 p.m. | #6
On 5/15/21 5:09 AM, Robert Foss wrote:
> Hey Randy,

> 

> I missed sending out a notification, but this patch was merged into

> drm-misc-next.

> 

> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=08319adbdde15ef7cee1970336f63461254baa2a


OK, thanks, Robert.

I was mainly asking because the 0day bot sent out a build failure
that this patch fixes, but it was dated 2021-MAY-05, so I guess I can
just ignore it, since it is so old. :)


> On Sat, 15 May 2021 at 07:35, Randy Dunlap <rdunlap@infradead.org> wrote:

>>

>> On 4/19/21 10:54 AM, Randy Dunlap wrote:

>>> On 4/19/21 10:10 AM, Randy Dunlap wrote:

>>>> On 4/19/21 2:01 AM, Robert Foss wrote:

>>>>> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency

>>>>> on EXTCON, which causes issues when sii8620 is built

>>>>> as a builtin and EXTCON is built as a module.

>>>>>

>>>>> The symptoms are 'undefined reference' errors caused

>>>>> by the symbols in EXTCON not being available

>>>>> to the sii8620 driver.

>>>>>

>>>>> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")

>>>>> Signed-off-by: Robert Foss <robert.foss@linaro.org>

>>>>> Reported-by: kernel test robot <lkp@intel.com>

>>>>> ---

>>>>>

>>>>> LKP reported issue:

>>>>> https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/

>>>>>

>>>>>

>>>>> Changes since v1:

>>>>>  - Fix typo on comment

>>>>>

>>>>> Changes since v2:

>>>>>  - Randy: Changed from `depends` to `select`

>>>>

>>>> I don't know why my name is on that. I didn't

>>>> suggest any change -- I just reported that v2

>>>> had a problem.

>>>>

>>>>

>>>>>

>>>>>

>>>>>  drivers/gpu/drm/bridge/Kconfig | 2 +-

>>>>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>>>>

>>>>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig

>>>>> index 22a467abd3e9..70402da5cc70 100644

>>>>> --- a/drivers/gpu/drm/bridge/Kconfig

>>>>> +++ b/drivers/gpu/drm/bridge/Kconfig

>>>>> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620

>>>>>     tristate "Silicon Image SII8620 HDMI/MHL bridge"

>>>>>     depends on OF

>>>>>     select DRM_KMS_HELPER

>>>>> -   imply EXTCON

>>>>> +   select EXTCON

>>>>>     depends on RC_CORE || !RC_CORE

>>>>>     help

>>>>>       Silicon Image SII8620 HDMI/MHL bridge chip driver.

>>>>

>>>>

>>>> Thanks. Works For Me.

>>>>

>>>> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

>>>

>>> Actually I can upgrade that to:

>>>

>>> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

>>

>> Hi,

>> Is anyone merging this patch?

>>

>> thanks.

>> --



-- 
~Randy

Patch

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 22a467abd3e9..70402da5cc70 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -169,7 +169,7 @@  config DRM_SIL_SII8620
 	tristate "Silicon Image SII8620 HDMI/MHL bridge"
 	depends on OF
 	select DRM_KMS_HELPER
-	imply EXTCON
+	select EXTCON
 	depends on RC_CORE || !RC_CORE
 	help
 	  Silicon Image SII8620 HDMI/MHL bridge chip driver.