From patchwork Mon Apr 19 09:07:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kai-Heng Feng X-Patchwork-Id: 424083 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 894BDC433B4 for ; Mon, 19 Apr 2021 09:08:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6ABD56113C for ; Mon, 19 Apr 2021 09:08:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238154AbhDSJIa (ORCPT ); Mon, 19 Apr 2021 05:08:30 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:51839 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232023AbhDSJI3 (ORCPT ); Mon, 19 Apr 2021 05:08:29 -0400 Received: from 36-229-230-199.dynamic-ip.hinet.net ([36.229.230.199] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lYPsr-0002tJ-Mg; Mon, 19 Apr 2021 09:07:58 +0000 From: Kai-Heng Feng To: rjw@rjwysocki.net Cc: Kai-Heng Feng , Len Brown , linux-acpi@vger.kernel.org (open list:ACPI), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ACPI: PM: s2idle: Invoke _PTS for s2idle Date: Mon, 19 Apr 2021 17:07:50 +0800 Message-Id: <20210419090750.1272562-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org HP EliteBook 840 G8 reboots on s2idle resume, and HP EliteBook 845 G8 wakes up immediately on s2idle. Both are caused by the XMM7360 WWAN PCI card. There's a WWAN specific method to really turn off the WWAN via EC: Method (_PTS, 1, NotSerialized) // _PTS: Prepare To Sleep { ... If (CondRefOf (\_SB.PCI0.GP12.PTS)) { \_SB.PCI0.GP12.PTS (Arg0) } ... } Scope (_SB.PCI0.GP12) { ... Method (PTS, 1, Serialized) { If (^^LPCB.EC0.ECRG) { If ((PDID == 0xFFFF)) { Return (Zero) } POFF () SGIO (WWBR, One) Sleep (0x1E) Acquire (^^LPCB.EC0.ECMX, 0xFFFF) ^^LPCB.EC0.WWP = One Release (^^LPCB.EC0.ECMX) Sleep (0x01F4) } Return (Zero) } ... } So let's also invok _PTS for s2idle. Signed-off-by: Kai-Heng Feng --- drivers/acpi/sleep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 09fd13757b65..7e84b4b09919 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@ -698,6 +698,7 @@ int acpi_s2idle_prepare(void) } acpi_enable_wakeup_devices(ACPI_STATE_S0); + acpi_enter_sleep_state_prep(ACPI_STATE_S0); /* Change the configuration of GPEs to avoid spurious wakeup. */ acpi_enable_all_wakeup_gpes();