| Message ID | 1618834662-20292-1-git-send-email-wangyunjian@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [net] net/mlx5e: Fix uninitialised struct field moder.comps | expand |
On Mon, 2021-04-19 at 20:17 +0800, wangyunjian wrote: > From: Yunjian Wang <wangyunjian@huawei.com> > > The 'comps' struct field in 'moder' is not being initialized > in mlx5e_get_def_rx_moderation(). So initialize 'moder' to > zero to avoid the issue. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 398c2b05bbee ("linux/dim: Add completions count to > dim_sample") net_dim doesn't use the comp value so there is no actual bug here. Can you please drop the Fixes line and resubmit resubmit this to net- next ... > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > index 5db63b9f3b70..9bcedfb0adfa 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > @@ -4881,7 +4881,7 @@ static struct dim_cq_moder > mlx5e_get_def_tx_moderation(u8 cq_period_mode) > > static struct dim_cq_moder mlx5e_get_def_rx_moderation(u8 > cq_period_mode) > { also mlx5e_get_def_tx_moderation needs fixing. Thanks for the patch, Saeed. > - struct dim_cq_moder moder; > + struct dim_cq_moder moder = {}; > > moder.cq_period_mode = cq_period_mode; > moder.pkts = MLX5E_PARAMS_DEFAULT_RX_CQ_MODERATION_PKTS;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index 5db63b9f3b70..9bcedfb0adfa 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -4881,7 +4881,7 @@ static struct dim_cq_moder mlx5e_get_def_tx_moderation(u8 cq_period_mode) static struct dim_cq_moder mlx5e_get_def_rx_moderation(u8 cq_period_mode) { - struct dim_cq_moder moder; + struct dim_cq_moder moder = {}; moder.cq_period_mode = cq_period_mode; moder.pkts = MLX5E_PARAMS_DEFAULT_RX_CQ_MODERATION_PKTS;