| Message ID | 549317B4.6080606@linaro.org |
|---|---|
| State | New |
| Headers | show
Return-Path: <patchwork-forward+bncBDMZP7MEUMLRBUVPZSSAKGQE7LARBRY@linaro.org> X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f70.google.com (mail-wg0-f70.google.com [74.125.82.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B5AD526C6B for <linaro@patches.linaro.org>; Thu, 18 Dec 2014 18:07:15 +0000 (UTC) Received: by mail-wg0-f70.google.com with SMTP id b13sf1166663wgh.1 for <linaro@patches.linaro.org>; Thu, 18 Dec 2014 10:07:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:organization :user-agent:mime-version:to:subject:cc:precedence:reply-to:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :content-type:content-transfer-encoding:errors-to:sender :x-original-sender:x-original-authentication-results:mailing-list; bh=2bIEPVz9VUZgVnH5aWZjNrYn+4Sfxgl9AsVynworwx4=; b=LhtSezSWhBulphZ+U8mYOrXTsAinnIEP13mDsDDiUP1fia6g2d3GNu5uNcEi0m03hw VDho+PUcpCxsD23ThhvZ4gh3t1UxHfH6EdWMHVXUnYmLo2CpR1oliwEdFkX30Ep7pmrr VoAxFA5lXWpdgDjdARbWkYgsI+xU377IovX2OsNpcL2j2x/GIi9oHxXvtLhqybMARiyU jR9WmvgqVndFCJ+EKSEDIu+n6Z6HnYsjvcb6rJaz9fR+H+MbDw9l4qD1jllR4xNt5o4q nbspSwlX84I60OSvRTGas4lrlT//bFB/yJM3+zR2w8bhWpRA9phfm/a8pkEmOPH8w5nK ksbg== X-Gm-Message-State: ALoCoQkgZuv9VWRD/8jbpfvRyEZg1z9Z0BjnO+/lRMDYy3mSqjbuRZF/EBUFd7feCRg+ASPYv12I X-Received: by 10.180.85.72 with SMTP id f8mr2343239wiz.0.1418926035047; Thu, 18 Dec 2014 10:07:15 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.28.67 with SMTP id z3ls992801lag.2.gmail; Thu, 18 Dec 2014 10:07:14 -0800 (PST) X-Received: by 10.152.23.38 with SMTP id j6mr3566778laf.81.1418926034882; Thu, 18 Dec 2014 10:07:14 -0800 (PST) Received: from mail-la0-f46.google.com (mail-la0-f46.google.com. [209.85.215.46]) by mx.google.com with ESMTPS id v7si7533890lag.130.2014.12.18.10.07.14 for <patchwork-forward@linaro.org> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 18 Dec 2014 10:07:14 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) client-ip=209.85.215.46; Received: by mail-la0-f46.google.com with SMTP id q1so1485534lam.33 for <patchwork-forward@linaro.org>; Thu, 18 Dec 2014 10:07:14 -0800 (PST) X-Received: by 10.112.189.10 with SMTP id ge10mr3529519lbc.23.1418926034550; Thu, 18 Dec 2014 10:07:14 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.142.69 with SMTP id ru5csp23605lbb; Thu, 18 Dec 2014 10:07:13 -0800 (PST) X-Received: by 10.170.59.203 with SMTP id b194mr3307059ykb.69.1418926032979; Thu, 18 Dec 2014 10:07:12 -0800 (PST) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id x109si9063955qge.94.2014.12.18.10.07.12 for <patch@linaro.org> (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 18 Dec 2014 10:07:12 -0800 (PST) Received-SPF: pass (google.com: domain of grub-devel-bounces+patch=linaro.org@gnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:55179 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <grub-devel-bounces+patch=linaro.org@gnu.org>) id 1Y1fTk-00021p-0N for patch@linaro.org; Thu, 18 Dec 2014 13:07:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <fu.wei@linaro.org>) id 1Y1fTS-00021R-Ph for grub-devel@gnu.org; Thu, 18 Dec 2014 13:07:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <fu.wei@linaro.org>) id 1Y1fTM-0004vg-T1 for grub-devel@gnu.org; Thu, 18 Dec 2014 13:06:54 -0500 Received: from mail-pd0-f180.google.com ([209.85.192.180]:46952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <fu.wei@linaro.org>) id 1Y1fTM-0004vc-Ns for grub-devel@gnu.org; Thu, 18 Dec 2014 13:06:48 -0500 Received: by mail-pd0-f180.google.com with SMTP id w10so1864713pde.39 for <grub-devel@gnu.org>; Thu, 18 Dec 2014 10:06:48 -0800 (PST) X-Received: by 10.70.35.207 with SMTP id k15mr5471947pdj.166.1418926008070; Thu, 18 Dec 2014 10:06:48 -0800 (PST) Received: from [192.168.1.11] ([59.58.226.187]) by mx.google.com with ESMTPSA id f1sm7314488pds.93.2014.12.18.10.06.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Dec 2014 10:06:47 -0800 (PST) Message-ID: <549317B4.6080606@linaro.org> Date: Fri, 19 Dec 2014 02:06:44 +0800 From: Fu Wei <fu.wei@linaro.org> Organization: Linaro User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: grub-devel@gnu.org, Leif Lindholm <leif.lindholm@linaro.org>, Ian Campbell <Ian.Campbell@citrix.com> Subject: [PATCH 3/5] arm64: Remove "loaded" checking in the grub_cmd_devicetree of linux.c X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.192.180 Cc: Roy Franz <roy.franz@linaro.org>, Jon Masters <jcm@redhat.com>, linaro-uefi <linaro-uefi@lists.linaro.org> X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB <grub-devel@gnu.org> List-Id: <patchwork-forward.linaro.org> List-Unsubscribe: <mailto:googlegroups-manage+836684582541+unsubscribe@googlegroups.com>, <http://groups.google.com/a/linaro.org/group/patchwork-forward/subscribe> List-Archive: <http://groups.google.com/a/linaro.org/group/patchwork-forward/> List-Post: <http://groups.google.com/a/linaro.org/group/patchwork-forward/post>, <mailto:patchwork-forward@linaro.org> List-Help: <http://support.google.com/a/linaro.org/bin/topic.py?topic=25838>, <mailto:patchwork-forward+help@linaro.org> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>, <mailto:grub-devel-request@gnu.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: grub-devel-bounces+patch=linaro.org@gnu.org Sender: grub-devel-bounces+patch=linaro.org@gnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: fu.wei@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 |
diff --git a/grub-core/loader/arm64/linux.c b/grub-core/loader/arm64/linux.c index 987f5b9..e9e9a29 100644 --- a/grub-core/loader/arm64/linux.c +++ b/grub-core/loader/arm64/linux.c @@ -185,13 +185,6 @@ grub_cmd_devicetree (grub_command_t cmd __attribute__ ((unused)), void *blob = NULL; int size; - if (!loaded) - { - grub_error (GRUB_ERR_BAD_ARGUMENT, - N_("you need to load the kernel first")); - return GRUB_ERR_BAD_OS; - } - if (argc != 1) return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("filename expected"));
Reason: (1)we don't need the check, actually (2)it is a prerequisite for multiboot support Signed-off-by: Fu Wei <fu.wei@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> --- grub-core/loader/arm64/linux.c | 7 ------- 1 file changed, 7 deletions(-)