| Message ID | 1418989601-14300-3-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 12/19/2014 03:04 PM, Stuart Haslam wrote: > On Fri, Dec 19, 2014 at 11:46:39AM +0000, Maxim Uvarov wrote: >> automake at least v 1.11.3 does not correctly recognize AM_TESTS_ENVIRONMENT. >> Just export this variable to be accessed thought make check run. >> >> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >> --- >> test/validation/Makefile.am | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am >> index db24ef4..1c8c5c7 100644 >> --- a/test/validation/Makefile.am >> +++ b/test/validation/Makefile.am >> @@ -3,7 +3,7 @@ include $(top_srcdir)/test/Makefile.inc >> AM_CFLAGS += -I$(srcdir)/common >> AM_LDFLAGS += -static >> >> -AM_TESTS_ENVIRONMENT = ODP_PLATFORM=${with_platform} >> +export ODP_PLATFORM=${with_platform} > Instead of this, can you try just changing the name, so; > > TESTS_ENVIRONMENT = ODP_PLATFORM=${with_platform} > > This seems to be the solution adopted elsewhere, e.g.; > > http://osdir.com/ml/bug-hello-gnu/2014-08/msg00001.html > That works. Can you check that TEST_ENVIRONMENT works on your system? Maxim.
On 12/19/2014 03:30 PM, Stuart Haslam wrote: > On Fri, Dec 19, 2014 at 12:17:49PM +0000, Maxim Uvarov wrote: >> On 12/19/2014 03:04 PM, Stuart Haslam wrote: >>> On Fri, Dec 19, 2014 at 11:46:39AM +0000, Maxim Uvarov wrote: >>>> automake at least v 1.11.3 does not correctly recognize AM_TESTS_ENVIRONMENT. >>>> Just export this variable to be accessed thought make check run. >>>> >>>> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >>>> --- >>>> test/validation/Makefile.am | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am >>>> index db24ef4..1c8c5c7 100644 >>>> --- a/test/validation/Makefile.am >>>> +++ b/test/validation/Makefile.am >>>> @@ -3,7 +3,7 @@ include $(top_srcdir)/test/Makefile.inc >>>> AM_CFLAGS += -I$(srcdir)/common >>>> AM_LDFLAGS += -static >>>> >>>> -AM_TESTS_ENVIRONMENT = ODP_PLATFORM=${with_platform} >>>> +export ODP_PLATFORM=${with_platform} >>> Instead of this, can you try just changing the name, so; >>> >>> TESTS_ENVIRONMENT = ODP_PLATFORM=${with_platform} >>> >>> This seems to be the solution adopted elsewhere, e.g.; >>> >>> http://osdir.com/ml/bug-hello-gnu/2014-08/msg00001.html >>> >> That works. Can you check that TEST_ENVIRONMENT works on your system? >> >> Maxim. > Yes it works on automake 1.14.1 > Ok, I will correct that in your patch in staging. Maxim.
diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am index db24ef4..1c8c5c7 100644 --- a/test/validation/Makefile.am +++ b/test/validation/Makefile.am @@ -3,7 +3,7 @@ include $(top_srcdir)/test/Makefile.inc AM_CFLAGS += -I$(srcdir)/common AM_LDFLAGS += -static -AM_TESTS_ENVIRONMENT = ODP_PLATFORM=${with_platform} +export ODP_PLATFORM=${with_platform} if ODP_CUNIT_ENABLED TESTS = odp_init odp_queue odp_crypto odp_shm odp_schedule odp_pktio_run
automake at least v 1.11.3 does not correctly recognize AM_TESTS_ENVIRONMENT. Just export this variable to be accessed thought make check run. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- test/validation/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)