[v2,6/7] mfd: wm831x: Correct kerneldoc

Message ID 20210420113929.278082-6-krzysztof.kozlowski@canonical.com
State New
Headers show
Series
  • [v2,1/7] mfd: max8997: Simplify getting of_device_id match data
Related show

Commit Message

Krzysztof Kozlowski April 20, 2021, 11:39 a.m.
Correct kerneldoc function name to fix W=1 warning:

  drivers/mfd/wm831x-core.c:121: warning:
    expecting prototype for wm831x_reg_unlock(). Prototype was for wm831x_reg_lock() instead

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

---

Changes since v1:
1. Add Ack
---
 drivers/mfd/wm831x-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lee Jones April 23, 2021, 8:05 a.m. | #1
On Tue, 20 Apr 2021, Krzysztof Kozlowski wrote:

> Correct kerneldoc function name to fix W=1 warning:

> 

>   drivers/mfd/wm831x-core.c:121: warning:

>     expecting prototype for wm831x_reg_unlock(). Prototype was for wm831x_reg_lock() instead

> 

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

> 

> ---

> 

> Changes since v1:

> 1. Add Ack

> ---

>  drivers/mfd/wm831x-core.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


FYI, a patch already exists for fixing this.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Patch

diff --git a/drivers/mfd/wm831x-core.c b/drivers/mfd/wm831x-core.c
index bcef08f58fb3..c31809b17547 100644
--- a/drivers/mfd/wm831x-core.c
+++ b/drivers/mfd/wm831x-core.c
@@ -109,7 +109,7 @@  static int wm831x_reg_locked(struct wm831x *wm831x, unsigned short reg)
 }
 
 /**
- * wm831x_reg_unlock: Unlock user keyed registers
+ * wm831x_reg_lock: Unlock user keyed registers
  *
  * The WM831x has a user key preventing writes to particularly
  * critical registers.  This function locks those registers,