diff mbox series

scsi: lpfc: remove redundant assignment to pointer temp_hdr

Message ID 20210420104123.376420-1-colin.king@canonical.com
State New
Headers show
Series scsi: lpfc: remove redundant assignment to pointer temp_hdr | expand

Commit Message

Colin King April 20, 2021, 10:41 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The pointer tmp_hdr is being assigned a value that is never
read, the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/lpfc/lpfc_sli.c | 1 -
 1 file changed, 1 deletion(-)

Comments

James Smart April 21, 2021, 8:20 p.m. UTC | #1 
On 4/20/2021 3:41 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>

> 

> The pointer tmp_hdr is being assigned a value that is never

> read, the assignment is redundant and can be removed.

> 

> Addresses-Coverity: ("Unused value")

> Signed-off-by: Colin Ian King <colin.king@canonical.com>

> ---


Thanks

Reviewed-by: James Smart <jsmart2021@gmail.com>


-- james
Martin K. Petersen April 27, 2021, 2:52 a.m. UTC | #2 
Colin,

> The pointer tmp_hdr is being assigned a value that is never read, the

> assignment is redundant and can be removed.


Applied to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Martin K. Petersen May 11, 2021, 3:25 a.m. UTC | #3 
On Tue, 20 Apr 2021 11:41:23 +0100, Colin King wrote:

> The pointer tmp_hdr is being assigned a value that is never

> read, the assignment is redundant and can be removed.


Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: lpfc: remove redundant assignment to pointer temp_hdr
      https://git.kernel.org/mkp/scsi/c/52b259908114

-- 
Martin K. Petersen	Oracle Linux Engineering
diff mbox series

Patch

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 06ccc0157bd8..9ead564dd0c0 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -17936,7 +17936,6 @@  lpfc_fc_frame_add(struct lpfc_vport *vport, struct hbq_dmabuf *dmabuf)
 	seq_dmabuf->time_stamp = jiffies;
 	lpfc_update_rcv_time_stamp(vport);
 	if (list_empty(&seq_dmabuf->dbuf.list)) {
-		temp_hdr = dmabuf->hbuf.virt;
 		list_add_tail(&dmabuf->dbuf.list, &seq_dmabuf->dbuf.list);
 		return seq_dmabuf;
 	}