[v2,7/7] mfd: twl: Correct kerneldoc

Message ID 20210420113929.278082-7-krzysztof.kozlowski@canonical.com
State New
Headers show
Series
  • [v2,1/7] mfd: max8997: Simplify getting of_device_id match data
Related show

Commit Message

Krzysztof Kozlowski April 20, 2021, 11:39 a.m.
Correct kerneldoc function name to fix W=1 warning:

  drivers/mfd/twl-core.c:496: warning:
    expecting prototype for twl_regcache_bypass(). Prototype was for twl_set_regcache_bypass() instead

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/mfd/twl-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Lee Jones April 23, 2021, 8:04 a.m. | #1
On Tue, 20 Apr 2021, Krzysztof Kozlowski wrote:

> Correct kerneldoc function name to fix W=1 warning:

> 

>   drivers/mfd/twl-core.c:496: warning:

>     expecting prototype for twl_regcache_bypass(). Prototype was for twl_set_regcache_bypass() instead

> 

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

> ---

>  drivers/mfd/twl-core.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)


FYI, a patch already exists for fixing this.

> diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c

> index 20cf8cfe4f3b..24b77b18b725 100644

> --- a/drivers/mfd/twl-core.c

> +++ b/drivers/mfd/twl-core.c

> @@ -485,8 +485,8 @@ int twl_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)

>  EXPORT_SYMBOL(twl_i2c_read);

>  

>  /**

> - * twl_regcache_bypass - Configure the regcache bypass for the regmap associated

> - *			 with the module

> + * twl_set_regcache_bypass - Configure the regcache bypass for the regmap

> + *			     associated with the module

>   * @mod_no: module number

>   * @enable: Regcache bypass state

>   *


-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Patch

diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 20cf8cfe4f3b..24b77b18b725 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -485,8 +485,8 @@  int twl_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
 EXPORT_SYMBOL(twl_i2c_read);
 
 /**
- * twl_regcache_bypass - Configure the regcache bypass for the regmap associated
- *			 with the module
+ * twl_set_regcache_bypass - Configure the regcache bypass for the regmap
+ *			     associated with the module
  * @mod_no: module number
  * @enable: Regcache bypass state
  *