[14/26] serial: meson: drop low-latency workaround

Message ID 20210421095509.3024-15-johan@kernel.org
State New
Headers show
  • tty: drop low-latency workarounds
Related show

Commit Message

Johan Hovold April 21, 2021, 9:54 a.m.
The meson driver has always carried an unnecessary workaround for the
infamous low_latency behaviour of tty_flip_buffer_push(), which had
already been removed by the time the driver was added by commit
ff7693d079e5 ("ARM: meson: serial: add MesonX SoC on-chip uart driver").

Specifically, since commit a9c3f68f3cd8 ("tty: Fix low_latency BUG"),
tty_flip_buffer_push() always schedules a work item to push data to the
line discipline and there's no need to keep any low_latency hacks around.

Signed-off-by: Johan Hovold <johan@kernel.org>
 drivers/tty/serial/meson_uart.c | 2 --
 1 file changed, 2 deletions(-)


diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
index 69eeef9edfa5..529cd0289056 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -226,9 +226,7 @@  static void meson_receive_chars(struct uart_port *port)
 	} while (!(readl(port->membase + AML_UART_STATUS) & AML_UART_RX_EMPTY));
-	spin_unlock(&port->lock);
-	spin_lock(&port->lock);
 static irqreturn_t meson_uart_interrupt(int irq, void *dev_id)