| Message ID | 20210421130105.1226686-120-gregkh@linuxfoundation.org |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On 21. 04. 21, 14:59, Greg Kroah-Hartman wrote: > This reverts commit 6734330654dac550f12e932996b868c6d0dcb421. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu <kjlu@umn.edu> > Cc: stable <stable@vger.kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/tty/serial/mxs-auart.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c > index f414d6acad69..edad6ebbdfd5 100644 > --- a/drivers/tty/serial/mxs-auart.c > +++ b/drivers/tty/serial/mxs-auart.c > @@ -1644,10 +1644,6 @@ static int mxs_auart_probe(struct platform_device *pdev) > > s->port.mapbase = r->start; > s->port.membase = ioremap(r->start, resource_size(r)); > - if (!s->port.membase) { > - ret = -ENOMEM; > - goto out_disable_clks; > - } I don't think this needs to be reverted -- the original fix is correct. > s->port.ops = &mxs_auart_ops; > s->port.iotype = UPIO_MEM; > s->port.fifosize = MXS_AUART_FIFO_SIZE; > -- js suse labs
On Thu, Apr 22, 2021 at 07:03:55AM +0200, Jiri Slaby wrote: > On 21. 04. 21, 14:59, Greg Kroah-Hartman wrote: > > This reverts commit 6734330654dac550f12e932996b868c6d0dcb421. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Kangjie Lu <kjlu@umn.edu> > > Cc: stable <stable@vger.kernel.org> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/tty/serial/mxs-auart.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c > > index f414d6acad69..edad6ebbdfd5 100644 > > --- a/drivers/tty/serial/mxs-auart.c > > +++ b/drivers/tty/serial/mxs-auart.c > > @@ -1644,10 +1644,6 @@ static int mxs_auart_probe(struct platform_device *pdev) > > s->port.mapbase = r->start; > > s->port.membase = ioremap(r->start, resource_size(r)); > > - if (!s->port.membase) { > > - ret = -ENOMEM; > > - goto out_disable_clks; > > - } > > I don't think this needs to be reverted -- the original fix is correct. > Now dropped, thanks for the review! greg k-h
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c index f414d6acad69..edad6ebbdfd5 100644 --- a/drivers/tty/serial/mxs-auart.c +++ b/drivers/tty/serial/mxs-auart.c @@ -1644,10 +1644,6 @@ static int mxs_auart_probe(struct platform_device *pdev) s->port.mapbase = r->start; s->port.membase = ioremap(r->start, resource_size(r)); - if (!s->port.membase) { - ret = -ENOMEM; - goto out_disable_clks; - } s->port.ops = &mxs_auart_ops; s->port.iotype = UPIO_MEM; s->port.fifosize = MXS_AUART_FIFO_SIZE;
This reverts commit 6734330654dac550f12e932996b868c6d0dcb421. Commits from @umn.edu addresses have been found to be submitted in "bad faith" to try to test the kernel community's ability to review "known malicious" changes. The result of these submissions can be found in a paper published at the 42nd IEEE Symposium on Security and Privacy entitled, "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu (University of Minnesota). Because of this, all submissions from this group must be reverted from the kernel tree and will need to be re-reviewed again to determine if they actually are a valid fix. Until that work is complete, remove this change to ensure that no problems are being introduced into the codebase. Cc: Kangjie Lu <kjlu@umn.edu> Cc: stable <stable@vger.kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/tty/serial/mxs-auart.c | 4 ---- 1 file changed, 4 deletions(-)