[2/2] thermal/core: Remove unused EXPORT_SYMBOLS

Message ID 20210422113457.51578-2-daniel.lezcano@linaro.org
State New
Headers show
Series
  • [1/2] thermal/drivers/tegra: Remove a pointless call get_thermal_instance()
Related show

Commit Message

Daniel Lezcano April 22, 2021, 11:34 a.m.
The functions exported in the thermal_helpers.c file are only used by
the governors and those are not compilable as module.

Remove the EXPORT_SYMBOL as no module code needs them.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

---
 .../driver-api/thermal/sysfs-api.rst          | 28 +------------------
 drivers/thermal/thermal_helpers.c             |  3 --
 2 files changed, 1 insertion(+), 30 deletions(-)

-- 
2.25.1

Comments

Viresh Kumar April 22, 2021, 11:53 a.m. | #1
On 22-04-21, 13:34, Daniel Lezcano wrote:
> The functions exported in the thermal_helpers.c file are only used by

> the governors and those are not compilable as module.

> 

> Remove the EXPORT_SYMBOL as no module code needs them.

> 

> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

> ---

>  .../driver-api/thermal/sysfs-api.rst          | 28 +------------------

>  drivers/thermal/thermal_helpers.c             |  3 --

>  2 files changed, 1 insertion(+), 30 deletions(-)

> 

> diff --git a/Documentation/driver-api/thermal/sysfs-api.rst b/Documentation/driver-api/thermal/sysfs-api.rst

> index 4b638c14bc16..c35266bbc119 100644

> --- a/Documentation/driver-api/thermal/sysfs-api.rst

> +++ b/Documentation/driver-api/thermal/sysfs-api.rst

> @@ -711,33 +711,7 @@ method, the sys I/F structure will be built like this::

>      |---temp1_input:		37000

>      |---temp1_crit:		100000

>  

> -4. Export Symbol APIs

> -=====================

> -

> -4.1. get_tz_trend

> ------------------

> -

> -This function returns the trend of a thermal zone, i.e the rate of change

> -of temperature of the thermal zone. Ideally, the thermal sensor drivers

> -are supposed to implement the callback. If they don't, the thermal

> -framework calculated the trend by comparing the previous and the current

> -temperature values.

> -

> -4.2. get_thermal_instance

> --------------------------

> -

> -This function returns the thermal_instance corresponding to a given

> -{thermal_zone, cooling_device, trip_point} combination. Returns NULL

> -if such an instance does not exist.

> -

> -4.3. thermal_cdev_update

> -------------------------

> -

> -This function serves as an arbitrator to set the state of a cooling

> -device. It sets the cooling device to the deepest cooling state if

> -possible.

> -

> -5. thermal_emergency_poweroff

> +4. thermal_emergency_poweroff

>  =============================

>  

>  On an event of critical trip temperature crossing. Thermal framework

> diff --git a/drivers/thermal/thermal_helpers.c b/drivers/thermal/thermal_helpers.c

> index 7f50f412e02a..0ecf2c66aa76 100644

> --- a/drivers/thermal/thermal_helpers.c

> +++ b/drivers/thermal/thermal_helpers.c

> @@ -39,7 +39,6 @@ int get_tz_trend(struct thermal_zone_device *tz, int trip)

>  

>  	return trend;

>  }

> -EXPORT_SYMBOL(get_tz_trend);

>  

>  struct thermal_instance *

>  get_thermal_instance(struct thermal_zone_device *tz,

> @@ -63,7 +62,6 @@ get_thermal_instance(struct thermal_zone_device *tz,

>  

>  	return target_instance;

>  }

> -EXPORT_SYMBOL(get_thermal_instance);

>  

>  /**

>   * thermal_zone_get_temp() - returns the temperature of a thermal zone

> @@ -221,7 +219,6 @@ void thermal_cdev_update(struct thermal_cooling_device *cdev)

>  	trace_cdev_update(cdev, target);

>  	dev_dbg(&cdev->device, "set to state %lu\n", target);

>  }

> -EXPORT_SYMBOL(thermal_cdev_update);

>  

>  /**

>   * thermal_zone_get_slope - return the slope attribute of the thermal zone


Acked-by: Viresh Kumar <viresh.kumar@linaro.org>


-- 
viresh

Patch

diff --git a/Documentation/driver-api/thermal/sysfs-api.rst b/Documentation/driver-api/thermal/sysfs-api.rst
index 4b638c14bc16..c35266bbc119 100644
--- a/Documentation/driver-api/thermal/sysfs-api.rst
+++ b/Documentation/driver-api/thermal/sysfs-api.rst
@@ -711,33 +711,7 @@  method, the sys I/F structure will be built like this::
     |---temp1_input:		37000
     |---temp1_crit:		100000
 
-4. Export Symbol APIs
-=====================
-
-4.1. get_tz_trend
------------------
-
-This function returns the trend of a thermal zone, i.e the rate of change
-of temperature of the thermal zone. Ideally, the thermal sensor drivers
-are supposed to implement the callback. If they don't, the thermal
-framework calculated the trend by comparing the previous and the current
-temperature values.
-
-4.2. get_thermal_instance
--------------------------
-
-This function returns the thermal_instance corresponding to a given
-{thermal_zone, cooling_device, trip_point} combination. Returns NULL
-if such an instance does not exist.
-
-4.3. thermal_cdev_update
-------------------------
-
-This function serves as an arbitrator to set the state of a cooling
-device. It sets the cooling device to the deepest cooling state if
-possible.
-
-5. thermal_emergency_poweroff
+4. thermal_emergency_poweroff
 =============================
 
 On an event of critical trip temperature crossing. Thermal framework
diff --git a/drivers/thermal/thermal_helpers.c b/drivers/thermal/thermal_helpers.c
index 7f50f412e02a..0ecf2c66aa76 100644
--- a/drivers/thermal/thermal_helpers.c
+++ b/drivers/thermal/thermal_helpers.c
@@ -39,7 +39,6 @@  int get_tz_trend(struct thermal_zone_device *tz, int trip)
 
 	return trend;
 }
-EXPORT_SYMBOL(get_tz_trend);
 
 struct thermal_instance *
 get_thermal_instance(struct thermal_zone_device *tz,
@@ -63,7 +62,6 @@  get_thermal_instance(struct thermal_zone_device *tz,
 
 	return target_instance;
 }
-EXPORT_SYMBOL(get_thermal_instance);
 
 /**
  * thermal_zone_get_temp() - returns the temperature of a thermal zone
@@ -221,7 +219,6 @@  void thermal_cdev_update(struct thermal_cooling_device *cdev)
 	trace_cdev_update(cdev, target);
 	dev_dbg(&cdev->device, "set to state %lu\n", target);
 }
-EXPORT_SYMBOL(thermal_cdev_update);
 
 /**
  * thermal_zone_get_slope - return the slope attribute of the thermal zone