diff mbox series

[v2] power: supply: cpcap-battery: fix invalid usage of list cursor

Message ID 20210421143650.16045-1-zhuguangqing83@gmail.com
State Accepted
Commit d0a43c12ee9f57ddb284272187bd18726c2c2c98
Headers show
Series [v2] power: supply: cpcap-battery: fix invalid usage of list cursor | expand

Commit Message

zhuguangqing83@gmail.com April 21, 2021, 2:36 p.m. UTC 
From: Guangqing Zhu <zhuguangqing83@gmail.com>

Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread().
Empty list or fully traversed list points to list head, which is not
NULL (and before the first element containing real data).

Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
---
v2:
  - Modify commit message and code as suggested by Sebastian.
---
 drivers/power/supply/cpcap-battery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
index 6d5bcdb9f45d..a3fc0084cda0 100644
--- a/drivers/power/supply/cpcap-battery.c
+++ b/drivers/power/supply/cpcap-battery.c
@@ -786,7 +786,7 @@  static irqreturn_t cpcap_battery_irq_thread(int irq, void *data)
 			break;
 	}
 
-	if (!d)
+	if (list_entry_is_head(d, &ddata->irq_list, node))
 		return IRQ_NONE;
 
 	latest = cpcap_battery_latest(ddata);