| Message ID | 20210422034302.yQ5OKt7Lt%akpm@linux-foundation.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | + coda-fix-reference-counting-in-coda_file_mmap-error-path.patch added to -mm tree | expand |
--- a/fs/coda/file.c~coda-fix-reference-counting-in-coda_file_mmap-error-path +++ a/fs/coda/file.c @@ -175,10 +175,10 @@ coda_file_mmap(struct file *coda_file, s ret = call_mmap(vma->vm_file, vma); if (ret) { - /* if call_mmap fails, our caller will put coda_file so we - * should drop the reference to the host_file that we got. + /* if call_mmap fails, our caller will put host_file so we + * should drop the reference to the coda_file that we got. */ - fput(host_file); + fput(coda_file); kfree(cvm_ops); } else { /* here we add redirects for the open/close vm_operations */
The patch titled Subject: coda: fix reference counting in coda_file_mmap error path has been added to the -mm tree. Its filename is coda-fix-reference-counting-in-coda_file_mmap-error-path.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/coda-fix-reference-counting-in-coda_file_mmap-error-path.patch and later at https://ozlabs.org/~akpm/mmotm/broken-out/coda-fix-reference-counting-in-coda_file_mmap-error-path.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Christian König <christian.koenig@amd.com> Subject: coda: fix reference counting in coda_file_mmap error path mmap_region() now calls fput() on the vma->vm_file. So we need to drop the extra reference on the coda file instead of the host file. Link: https://lkml.kernel.org/r/20210421132012.82354-1-christian.koenig@amd.com Fixes: 1527f926fd04 ("mm: mmap: fix fput in error path v2") Signed-off-by: Christian König <christian.koenig@amd.com> Cc: Jan Harkes <jaharkes@cs.cmu.edu> Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: <stable@vger.kernel.org> [5.11+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- fs/coda/file.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)