| Message ID | 161918455721.3145707.4063925145568978308.stgit@warthog.procyon.org.uk |
|---|---|
| State | New |
| Headers | show |
| Series | Network fs helper library & fscache kiocb API | expand |
Hi David, On Fri, Apr 23, 2021 at 3:31 PM David Howells <dhowells@redhat.com> wrote: > Make a netfs helper module to manage read request segmentation, caching > support and transparent huge page support on behalf of a network > filesystem. > > Signed-off-by: David Howells <dhowells@redhat.com> Thanks for your patch, which is now commit 3ca236440126f75c ("mm: Implement readahead_control pageset expansion") upstream. > --- /dev/null > +++ b/fs/netfs/Kconfig > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +config NETFS_SUPPORT > + tristate "Support for network filesystem high-level I/O" > + help > + This option enables support for network filesystems, including > + helpers for high-level buffered I/O, abstracting out read > + segmentation, local caching and transparent huge page support. TBH, this help text didn't give me any clue on whether I want to enable this config option or not. Do I need it for e.g. NFS, which is a network filesystem? I see later patches make AFS and FSCACHE select NETFS_SUPPORT. If this is just a library of functions, to be selected by its users, then please make the symbol invisible. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Geert Uytterhoeven <geert@linux-m68k.org> wrote: > I see later patches make AFS and FSCACHE select NETFS_SUPPORT. If this > is just a library of functions, to be selected by its users, then please > make the symbol invisible. Ideally, yes, it would be an invisible symbol enabled by select from the network filesystems that use it - but doing that means that you can't choose whether to build it in or build it as a module. David
David Howells wrote on Thu, Apr 29, 2021 at 09:41:37AM +0100: > Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > I see later patches make AFS and FSCACHE select NETFS_SUPPORT. If this > > is just a library of functions, to be selected by its users, then please > > make the symbol invisible. > > Ideally, yes, it would be an invisible symbol enabled by select from the > network filesystems that use it - but doing that means that you can't choose > whether to build it in or build it as a module. Afaik such dependencies are then built as a module if everything it depends on are modules, and built-in if any of these are built-in. I think most users would be fine with that -- there's little reason to have netfs built-in if AFS ceph etc all are modules? -- Dominique
diff --git a/fs/netfs/Kconfig b/fs/netfs/Kconfig new file mode 100644 index 000000000000..2ebf90e6ca95 --- /dev/null +++ b/fs/netfs/Kconfig @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config NETFS_SUPPORT + tristate "Support for network filesystem high-level I/O" + help + This option enables support for network filesystems, including + helpers for high-level buffered I/O, abstracting out read + segmentation, local caching and transparent huge page support.