| Message ID | 1619345672-31802-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | esp: drop unneeded assignment in esp4_gro_receive() | expand |
On Sun, Apr 25, 2021 at 06:14:32PM +0800, Yang Li wrote: > Making '!=' operation with 0 directly after calling > the function xfrm_parse_spi() is more efficient, > assignment to err is redundant. > > Eliminate the following clang_analyzer warning: > net/ipv4/esp4_offload.c:41:7: warning: Although the value stored to > 'err' is used in the enclosing expression, the value is never actually > read from 'err' > > No functional change, only more efficient. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Now applied to ipsec-next, thanks!
diff --git a/net/ipv4/esp4_offload.c b/net/ipv4/esp4_offload.c index 33687cf..be019a1 100644 --- a/net/ipv4/esp4_offload.c +++ b/net/ipv4/esp4_offload.c @@ -33,12 +33,11 @@ static struct sk_buff *esp4_gro_receive(struct list_head *head, struct xfrm_state *x; __be32 seq; __be32 spi; - int err; if (!pskb_pull(skb, offset)) return NULL; - if ((err = xfrm_parse_spi(skb, IPPROTO_ESP, &spi, &seq)) != 0) + if (xfrm_parse_spi(skb, IPPROTO_ESP, &spi, &seq) != 0) goto out; xo = xfrm_offload(skb);
Making '!=' operation with 0 directly after calling the function xfrm_parse_spi() is more efficient, assignment to err is redundant. Eliminate the following clang_analyzer warning: net/ipv4/esp4_offload.c:41:7: warning: Although the value stored to 'err' is used in the enclosing expression, the value is never actually read from 'err' No functional change, only more efficient. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- net/ipv4/esp4_offload.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)