[thermal:,thermal/next] thermal/drivers/hisi: Remove redundant dev_err call in hisi_thermal_probe()

Message ID 161955267329.29796.10846130053666149008.tip-bot2@tip-bot2
State New
Headers show
Series
  • [thermal:,thermal/next] thermal/drivers/hisi: Remove redundant dev_err call in hisi_thermal_probe()
Related show

Commit Message

tip-bot2 for Thomas Gleixner April 27, 2021, 7:44 p.m.
The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     beaa41029fdea9d3e01af3a1a800538542d30869
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//beaa41029fdea9d3e01af3a1a800538542d30869
Author:        Ye Bin <yebin10@huawei.com>
AuthorDate:    Fri, 09 Apr 2021 15:52:24 +08:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Tue, 20 Apr 2021 09:18:57 +02:00

thermal/drivers/hisi: Remove redundant dev_err call in hisi_thermal_probe()

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210409075224.2109503-1-yebin10@huawei.com
---
 drivers/thermal/hisi_thermal.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Patch

diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index d902db9..9a21ac0 100644
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -572,10 +572,8 @@  static int hisi_thermal_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	data->regs = devm_ioremap_resource(dev, res);
-	if (IS_ERR(data->regs)) {
-		dev_err(dev, "failed to get io address\n");
+	if (IS_ERR(data->regs))
 		return PTR_ERR(data->regs);
-	}
 
 	ret = data->ops->probe(data);
 	if (ret)