[02/12] pinctrl: renesas: r8a77990: JTAG pins do not have pull-down capabilities

Message ID da4b2d69955840a506412f1e8099607a0da97ecc.1619785375.git.geert+renesas@glider.be
State New
Headers show
Series
  • Untitled series #124135
Related show

Commit Message

Geert Uytterhoeven April 30, 2021, 12:31 p.m.
Hence remove the SH_PFC_PIN_CFG_PULL_DOWN flags from their pin
descriptions.

Fixes: 83f6941a42a5e773 ("pinctrl: sh-pfc: r8a77990: Add bias pinconf support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pinctrl/renesas/pfc-r8a77990.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Niklas Söderlund May 1, 2021, 7:19 a.m. | #1
Hi Geert,

Thanks for your work.

On 2021-04-30 14:31:01 +0200, Geert Uytterhoeven wrote:
> Hence remove the SH_PFC_PIN_CFG_PULL_DOWN flags from their pin

> descriptions.

> 

> Fixes: 83f6941a42a5e773 ("pinctrl: sh-pfc: r8a77990: Add bias pinconf support")

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>


Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>


> ---

>  drivers/pinctrl/renesas/pfc-r8a77990.c | 8 ++++----

>  1 file changed, 4 insertions(+), 4 deletions(-)

> 

> diff --git a/drivers/pinctrl/renesas/pfc-r8a77990.c b/drivers/pinctrl/renesas/pfc-r8a77990.c

> index d040eb3e305daf40..eeebbab4dd811f9c 100644

> --- a/drivers/pinctrl/renesas/pfc-r8a77990.c

> +++ b/drivers/pinctrl/renesas/pfc-r8a77990.c

> @@ -53,10 +53,10 @@

>  	PIN_NOGP_CFG(FSCLKST_N, "FSCLKST_N", fn, CFG_FLAGS),		\

>  	PIN_NOGP_CFG(MLB_REF, "MLB_REF", fn, CFG_FLAGS),		\

>  	PIN_NOGP_CFG(PRESETOUT_N, "PRESETOUT_N", fn, CFG_FLAGS),	\

> -	PIN_NOGP_CFG(TCK, "TCK", fn, CFG_FLAGS),			\

> -	PIN_NOGP_CFG(TDI, "TDI", fn, CFG_FLAGS),			\

> -	PIN_NOGP_CFG(TMS, "TMS", fn, CFG_FLAGS),			\

> -	PIN_NOGP_CFG(TRST_N, "TRST_N", fn, CFG_FLAGS)

> +	PIN_NOGP_CFG(TCK, "TCK", fn, SH_PFC_PIN_CFG_PULL_UP),		\

> +	PIN_NOGP_CFG(TDI, "TDI", fn, SH_PFC_PIN_CFG_PULL_UP),		\

> +	PIN_NOGP_CFG(TMS, "TMS", fn, SH_PFC_PIN_CFG_PULL_UP),		\

> +	PIN_NOGP_CFG(TRST_N, "TRST_N", fn, SH_PFC_PIN_CFG_PULL_UP)

>  

>  /*

>   * F_() : just information

> -- 

> 2.25.1

> 


-- 
Regards,
Niklas Söderlund

Patch

diff --git a/drivers/pinctrl/renesas/pfc-r8a77990.c b/drivers/pinctrl/renesas/pfc-r8a77990.c
index d040eb3e305daf40..eeebbab4dd811f9c 100644
--- a/drivers/pinctrl/renesas/pfc-r8a77990.c
+++ b/drivers/pinctrl/renesas/pfc-r8a77990.c
@@ -53,10 +53,10 @@ 
 	PIN_NOGP_CFG(FSCLKST_N, "FSCLKST_N", fn, CFG_FLAGS),		\
 	PIN_NOGP_CFG(MLB_REF, "MLB_REF", fn, CFG_FLAGS),		\
 	PIN_NOGP_CFG(PRESETOUT_N, "PRESETOUT_N", fn, CFG_FLAGS),	\
-	PIN_NOGP_CFG(TCK, "TCK", fn, CFG_FLAGS),			\
-	PIN_NOGP_CFG(TDI, "TDI", fn, CFG_FLAGS),			\
-	PIN_NOGP_CFG(TMS, "TMS", fn, CFG_FLAGS),			\
-	PIN_NOGP_CFG(TRST_N, "TRST_N", fn, CFG_FLAGS)
+	PIN_NOGP_CFG(TCK, "TCK", fn, SH_PFC_PIN_CFG_PULL_UP),		\
+	PIN_NOGP_CFG(TDI, "TDI", fn, SH_PFC_PIN_CFG_PULL_UP),		\
+	PIN_NOGP_CFG(TMS, "TMS", fn, SH_PFC_PIN_CFG_PULL_UP),		\
+	PIN_NOGP_CFG(TRST_N, "TRST_N", fn, SH_PFC_PIN_CFG_PULL_UP)
 
 /*
  * F_() : just information