scsi: target: configfs: Remove redundant assignment to ret

Message ID 1619774627-118766-1-git-send-email-jiapeng.chong@linux.alibaba.com
State New
Headers show
Series
  • scsi: target: configfs: Remove redundant assignment to ret
Related show

Commit Message

Jiapeng Chong April 30, 2021, 9:23 a.m.
Variable ret is set to '-EINVAL' but this value is never read as it is
overwritten later on, hence it is a redundant assignment and can be
removed.

Clean up the following clang-analyzer warning:

drivers/target/target_core_configfs.c:2037:5: warning: Value stored to
'ret' is never read [clang-analyzer-deadcode.DeadStores].

drivers/target/target_core_configfs.c:1973:5: warning: Value stored to
'ret' is never read [clang-analyzer-deadcode.DeadStores].

drivers/target/target_core_configfs.c:1959:5: warning: Value stored to
'ret' is never read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/target/target_core_configfs.c | 3 ---
 1 file changed, 3 deletions(-)

Patch

diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 4b2e493..bda05c3 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -1956,7 +1956,6 @@  static ssize_t target_pr_res_aptpl_metadata_store(struct config_item *item,
 				pr_err("APTPL metadata initiator_node="
 					" exceeds PR_APTPL_MAX_IPORT_LEN: %d\n",
 					PR_APTPL_MAX_IPORT_LEN);
-				ret = -EINVAL;
 				break;
 			}
 			break;
@@ -1970,7 +1969,6 @@  static ssize_t target_pr_res_aptpl_metadata_store(struct config_item *item,
 				pr_err("APTPL metadata initiator_isid"
 					"= exceeds PR_REG_ISID_LEN: %d\n",
 					PR_REG_ISID_LEN);
-				ret = -EINVAL;
 				break;
 			}
 			break;
@@ -2034,7 +2032,6 @@  static ssize_t target_pr_res_aptpl_metadata_store(struct config_item *item,
 				pr_err("APTPL metadata target_node="
 					" exceeds PR_APTPL_MAX_TPORT_LEN: %d\n",
 					PR_APTPL_MAX_TPORT_LEN);
-				ret = -EINVAL;
 				break;
 			}
 			break;