| Message ID | 20210504222915.17206-16-ansuelsmth@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Multiple improvement to qca8k stability | expand |
On Wed, May 05, 2021 at 12:29:10AM +0200, Ansuel Smith wrote: > - Enlarge set page delay to QDSK source > - Enlarge mdio MASTER timeout busy wait > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- Some "why"s would go a long way here. What did you see? What behaves differently? Is this only a preventative change?
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 27234dd4c74a..b4cd891ad35d 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -140,6 +140,7 @@ qca8k_set_page(struct mii_bus *bus, u16 page) } qca8k_current_page = page; + usleep_range(1000, 2000); return 0; } @@ -641,7 +642,7 @@ qca8k_mdio_busy_wait(struct qca8k_priv *priv, u32 reg, u32 mask) qca8k_split_addr(reg, &r1, &r2, &page); - timeout = jiffies + msecs_to_jiffies(20); + timeout = jiffies + msecs_to_jiffies(2000); /* loop until the busy flag has cleared */ do {
- Enlarge set page delay to QDSK source - Enlarge mdio MASTER timeout busy wait Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- drivers/net/dsa/qca8k.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)