[V4,8/8] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp

Message ID 1620197726-23802-9-git-send-email-skakit@codeaurora.org
State New
Headers show
Series
  • Add PMIC DT files for sc7280
Related show

Commit Message

satya priya May 5, 2021, 6:55 a.m.
The sc7280-idp has four PMICs, include their .dtsi files.

Signed-off-by: satya priya <skakit@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Matthias Kaehlcke May 5, 2021, 2:57 p.m. | #1
On Wed, May 05, 2021 at 12:25:26PM +0530, satya priya wrote:
> The sc7280-idp has four PMICs, include their .dtsi files.
> 
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> index 02a14fc..704fb9a 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> @@ -12,6 +12,10 @@
>  #include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
>  #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
>  #include "sc7280.dtsi"
> +#include "pm7325.dtsi"
> +#include "pmr735a.dtsi"
> +#include "pm8350c.dtsi"
> +#include "pmk8350.dtsi"

Patch '[7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp'
of this series makes use of the label 'pmk8350_vadc', which doesn't exist
at that point.

A series should be organized in a way that applying only a
subset of the series (in order, starting with patch 1) doesn't
cause any build or runtime issues. To achieve this patch [7/8]
and [8/8] of this series need to be swapped.
satya priya May 17, 2021, 5:27 a.m. | #2
On 2021-05-05 20:27, Matthias Kaehlcke wrote:
> On Wed, May 05, 2021 at 12:25:26PM +0530, satya priya wrote:

>> The sc7280-idp has four PMICs, include their .dtsi files.

>> 

>> Signed-off-by: satya priya <skakit@codeaurora.org>

>> ---

>>  arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++

>>  1 file changed, 4 insertions(+)

>> 

>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts 

>> b/arch/arm64/boot/dts/qcom/sc7280-idp.dts

>> index 02a14fc..704fb9a 100644

>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts

>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts

>> @@ -12,6 +12,10 @@

>>  #include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>

>>  #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>

>>  #include "sc7280.dtsi"

>> +#include "pm7325.dtsi"

>> +#include "pmr735a.dtsi"

>> +#include "pm8350c.dtsi"

>> +#include "pmk8350.dtsi"

> 

> Patch '[7/8] arm64: dts: qcom: sc7280: Add channel nodes for 

> sc7280-idp'

> of this series makes use of the label 'pmk8350_vadc', which doesn't 

> exist

> at that point.

> 

> A series should be organized in a way that applying only a

> subset of the series (in order, starting with patch 1) doesn't

> cause any build or runtime issues. To achieve this patch [7/8]

> and [8/8] of this series need to be swapped.


Okay, I will re-arrange the series and resend v4.

Thanks,
Satya Priya

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 02a14fc..704fb9a 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -12,6 +12,10 @@ 
 #include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
 #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
 #include "sc7280.dtsi"
+#include "pm7325.dtsi"
+#include "pmr735a.dtsi"
+#include "pm8350c.dtsi"
+#include "pmk8350.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. sc7280 IDP platform";