net: wireless: zydas: Prefer pr_err over printk error msg

Message ID 20210506044838.GA7260@user
State New
Headers show
Series
  • net: wireless: zydas: Prefer pr_err over printk error msg
Related show

Commit Message

Saurav Girepunje May 6, 2021, 4:48 a.m.
In zd_usb.c usb_init we can prefer pr_err() over printk KERN_ERR
log level.

Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
 drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.25.1

Comments

Kalle Valo June 15, 2021, 1:37 p.m. | #1
Saurav Girepunje <saurav.girepunje@gmail.com> wrote:

> In zd_usb.c usb_init we can prefer pr_err() over printk KERN_ERR

> log level.

> 

> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>


Patch applied to wireless-drivers-next.git, thanks.

29d97219f403 zd1211rw: Prefer pr_err over printk error msg

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210506044838.GA7260@user/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Patch

diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
index 5c4cd0e1adeb..a7ceef10bf6a 100644
--- a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
+++ b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
@@ -1544,14 +1544,14 @@  static int __init usb_init(void)

 	zd_workqueue = create_singlethread_workqueue(driver.name);
 	if (zd_workqueue == NULL) {
-		printk(KERN_ERR "%s couldn't create workqueue\n", driver.name);
+		pr_err("%s couldn't create workqueue\n", driver.name);
 		return -ENOMEM;
 	}

 	r = usb_register(&driver);
 	if (r) {
 		destroy_workqueue(zd_workqueue);
-		printk(KERN_ERR "%s usb_register() failed. Error number %d\n",
+		pr_err("%s usb_register() failed. Error number %d\n",
 		       driver.name, r);
 		return r;
 	}