[1/3] dt-bindings: pci: qcom: Document PCIe bindings for SC720

Message ID 1620382648-17395-2-git-send-email-pmaliset@codeaurora.org
State Superseded
Headers show
Series
  • Add DT bindings and DT nodes for PCIe and PHY in SC7280
Related show

Commit Message

Prasad Malisetty May 7, 2021, 10:17 a.m.
Document the PCIe DT bindings for SC7280 SoC.The PCIe IP is similar
to the one used on SM8250. Add the compatible for SC7280.

Signed-off-by: Prasad Malisetty <pmaliset@codeaurora.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie.txt | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Rob Herring May 10, 2021, 3:48 p.m. | #1
On Fri, 07 May 2021 15:47:26 +0530, Prasad Malisetty wrote:
> Document the PCIe DT bindings for SC7280 SoC.The PCIe IP is similar
> to the one used on SM8250. Add the compatible for SC7280.
> 
> Signed-off-by: Prasad Malisetty <pmaliset@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/pci/qcom,pcie.txt | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Stephen Boyd June 4, 2021, 9:44 p.m. | #2
Quoting Prasad Malisetty (2021-06-04 04:26:57)
> On 2021-05-08 01:29, Stephen Boyd wrote:

> > Quoting Prasad Malisetty (2021-05-07 03:17:26)

> >> Document the PCIe DT bindings for SC7280 SoC.The PCIe IP is similar

> >> to the one used on SM8250. Add the compatible for SC7280.

> >>

> >> Signed-off-by: Prasad Malisetty <pmaliset@codeaurora.org>

> >> ---

> >>  Documentation/devicetree/bindings/pci/qcom,pcie.txt | 17

> >> +++++++++++++++++

> >>  1 file changed, 17 insertions(+)

> >>

> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt

> >> b/Documentation/devicetree/bindings/pci/qcom,pcie.txt

> >> index 0da458a..e5245ed 100644

> >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt

> >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt

> >> @@ -12,6 +12,7 @@

> >>                         - "qcom,pcie-ipq4019" for ipq4019

> >>                         - "qcom,pcie-ipq8074" for ipq8074

> >>                         - "qcom,pcie-qcs404" for qcs404

> >> +                       - "qcom,pcie-sc7280" for sc7280

> >>                         - "qcom,pcie-sdm845" for sdm845

> >>                         - "qcom,pcie-sm8250" for sm8250

> >>

> >> @@ -133,6 +134,22 @@

> >>                         - "slave_bus"   AXI Slave clock

> >>

> >>  - clock-names:

> >> +       Usage: required for sc7280

> >> +       Value type: <stringlist>

> >> +       Definition: Should contain the following entries

> >> +                       - "aux"         Auxiliary clock

> >> +                       - "cfg"         Configuration clock

> >> +                       - "bus_master"  Master AXI clock

> >> +                       - "bus_slave"   Slave AXI clock

> >> +                       - "slave_q2a"   Slave Q2A clock

> >> +                       - "tbu"         PCIe TBU clock

> >> +                       - "ddrss_sf_tbu" PCIe SF TBU clock

> >> +                       - "pipe"        PIPE clock

> >> +                       - "pipe_src"    PIPE MUX

> >

> > Is pipe_src necessary? Is it the parent of the pipe clk? If so, please

> > remove it and do whatever is necessary on the pipe clk instead of the

> > parent of the clk.

>

> Here pipe_src is MUX. Newer targets require changing pipe-clk mux to

> switch between pipe_clk and XO for GDSC enable.

> After PHY init, need to configure MUX.


Ok. I see, so we have to change the parent of the parent of the pipe
clk?

Patch

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
index 0da458a..e5245ed 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
@@ -12,6 +12,7 @@ 
 			- "qcom,pcie-ipq4019" for ipq4019
 			- "qcom,pcie-ipq8074" for ipq8074
 			- "qcom,pcie-qcs404" for qcs404
+			- "qcom,pcie-sc7280" for sc7280
 			- "qcom,pcie-sdm845" for sdm845
 			- "qcom,pcie-sm8250" for sm8250
 
@@ -133,6 +134,22 @@ 
 			- "slave_bus"	AXI Slave clock
 
 - clock-names:
+	Usage: required for sc7280
+	Value type: <stringlist>
+	Definition: Should contain the following entries
+			- "aux"         Auxiliary clock
+			- "cfg"         Configuration clock
+			- "bus_master"  Master AXI clock
+			- "bus_slave"   Slave AXI clock
+			- "slave_q2a"   Slave Q2A clock
+			- "tbu"         PCIe TBU clock
+			- "ddrss_sf_tbu" PCIe SF TBU clock
+			- "pipe"        PIPE clock
+			- "pipe_src"    PIPE MUX
+			- "pipe_ext"    PIPE output clock
+			- "ref"         REFERENCE clock
+
+- clock-names:
 	Usage: required for sdm845
 	Value type: <stringlist>
 	Definition: Should contain the following entries