neighbour: Remove redundant initialization of 'bucket'

Message ID 1620468185-122101-1-git-send-email-yang.lee@linux.alibaba.com
State New
Headers show
Series
  • neighbour: Remove redundant initialization of 'bucket'
Related show

Commit Message

Yang Li May 8, 2021, 10:03 a.m.
Integer variable 'bucket' is being initialized however
this value is never read as 'bucket' is assigned zero
in for statement. Remove the redundant assignment.

Cleans up clang warning:

net/core/neighbour.c:3144:6: warning: Value stored to 'bucket' during
its initialization is never read [clang-analyzer-deadcode.DeadStores]

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 net/core/neighbour.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org May 10, 2021, 9:30 p.m. | #1
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat,  8 May 2021 18:03:05 +0800 you wrote:
> Integer variable 'bucket' is being initialized however

> this value is never read as 'bucket' is assigned zero

> in for statement. Remove the redundant assignment.

> 

> Cleans up clang warning:

> 

> net/core/neighbour.c:3144:6: warning: Value stored to 'bucket' during

> its initialization is never read [clang-analyzer-deadcode.DeadStores]

> 

> [...]


Here is the summary with links:
  - neighbour: Remove redundant initialization of 'bucket'
    https://git.kernel.org/netdev/net-next/c/48de7c0c1c92

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Patch

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 98f20efb..2b2f333 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -3141,7 +3141,7 @@  static struct pneigh_entry *pneigh_get_first(struct seq_file *seq)
 	struct net *net = seq_file_net(seq);
 	struct neigh_table *tbl = state->tbl;
 	struct pneigh_entry *pn = NULL;
-	int bucket = state->bucket;
+	int bucket;
 
 	state->flags |= NEIGH_SEQ_IS_PNEIGH;
 	for (bucket = 0; bucket <= PNEIGH_HASHMASK; bucket++) {