| Message ID | 20210510145117.4066-1-thunder.leizhen@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] b43: phy_n: Delete some useless empty code | expand |
On 2021/5/11 4:02, Andrew Lunn wrote: > On Mon, May 10, 2021 at 10:51:17PM +0800, Zhen Lei wrote: >> These TODO empty code are added by >> commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's >> been more than a decade now. I don't think anyone who wants to perfect >> this workaround can follow this TODO tip exactly. Instead, it limits them >> to new thinking. Remove it will be better. >> >> No functional change. > > No function change, apart from the new warning? > > Does your bot to compile the change and look for new warnings/errors? Sorry, I have compiled it. I guess it's probably separated by macros, which I didn't notice. I will check it. > > Andrew > > . >
diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c b/drivers/net/wireless/broadcom/b43/phy_n.c index 665b737fbb0d820..13cc62695f4cc93 100644 --- a/drivers/net/wireless/broadcom/b43/phy_n.c +++ b/drivers/net/wireless/broadcom/b43/phy_n.c @@ -4601,16 +4601,6 @@ static void b43_nphy_spur_workaround(struct b43_wldev *dev) if (nphy->hang_avoid) b43_nphy_stay_in_carrier_search(dev, 1); - if (nphy->gband_spurwar_en) { - /* TODO: N PHY Adjust Analog Pfbw (7) */ - if (channel == 11 && b43_is_40mhz(dev)) { - ; /* TODO: N PHY Adjust Min Noise Var(2, tone, noise)*/ - } else { - ; /* TODO: N PHY Adjust Min Noise Var(0, NULL, NULL)*/ - } - /* TODO: N PHY Adjust CRS Min Power (0x1E) */ - } - if (nphy->aband_spurwar_en) { if (channel == 54) { tone[0] = 0x20; @@ -4636,12 +4626,6 @@ static void b43_nphy_spur_workaround(struct b43_wldev *dev) tone[0] = 0; noise[0] = 0; } - - if (!tone[0] && !noise[0]) { - ; /* TODO: N PHY Adjust Min Noise Var(1, tone, noise)*/ - } else { - ; /* TODO: N PHY Adjust Min Noise Var(0, NULL, NULL)*/ - } } if (nphy->hang_avoid)
These TODO empty code are added by commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's been more than a decade now. I don't think anyone who wants to perfect this workaround can follow this TODO tip exactly. Instead, it limits them to new thinking. Remove it will be better. No functional change. Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/net/wireless/broadcom/b43/phy_n.c | 16 ---------------- 1 file changed, 16 deletions(-)