[1/1] power: reset: at91-sama5d2_shdwc: Remove redundant error printing in at91_shdwc_probe()

Message ID 20210511094919.4885-1-thunder.leizhen@huawei.com
State New
Headers show
Series
  • [1/1] power: reset: at91-sama5d2_shdwc: Remove redundant error printing in at91_shdwc_probe()
Related show

Commit Message

Zhen Lei May 11, 2021, 9:49 a.m.
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

---
 drivers/power/reset/at91-sama5d2_shdwc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

-- 
2.26.0.106.g9fadedd

Comments

Sebastian Reichel June 4, 2021, 11:05 a.m. | #1
Hi,

On Tue, May 11, 2021 at 05:49:19PM +0800, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be

> printed by its subfunction __devm_ioremap_resource(). The error

> information contains the device name, failure cause, and possibly resource

> information.

> 

> Therefore, remove the error printing here to simplify code and reduce the

> binary size.

> 

> Reported-by: Hulk Robot <hulkci@huawei.com>

> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

> ---


Thanks, queued.

-- Sebastian

>  drivers/power/reset/at91-sama5d2_shdwc.c | 4 +---

>  1 file changed, 1 insertion(+), 3 deletions(-)

> 

> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c

> index 125e592af445e32..d8ecffe72f165cb 100644

> --- a/drivers/power/reset/at91-sama5d2_shdwc.c

> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c

> @@ -351,10 +351,8 @@ static int __init at91_shdwc_probe(struct platform_device *pdev)

>  

>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

>  	at91_shdwc->shdwc_base = devm_ioremap_resource(&pdev->dev, res);

> -	if (IS_ERR(at91_shdwc->shdwc_base)) {

> -		dev_err(&pdev->dev, "Could not map reset controller address\n");

> +	if (IS_ERR(at91_shdwc->shdwc_base))

>  		return PTR_ERR(at91_shdwc->shdwc_base);

> -	}

>  

>  	match = of_match_node(at91_shdwc_of_match, pdev->dev.of_node);

>  	at91_shdwc->rcfg = match->data;

> -- 

> 2.26.0.106.g9fadedd

> 

>

Patch

diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
index 125e592af445e32..d8ecffe72f165cb 100644
--- a/drivers/power/reset/at91-sama5d2_shdwc.c
+++ b/drivers/power/reset/at91-sama5d2_shdwc.c
@@ -351,10 +351,8 @@  static int __init at91_shdwc_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	at91_shdwc->shdwc_base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(at91_shdwc->shdwc_base)) {
-		dev_err(&pdev->dev, "Could not map reset controller address\n");
+	if (IS_ERR(at91_shdwc->shdwc_base))
 		return PTR_ERR(at91_shdwc->shdwc_base);
-	}
 
 	match = of_match_node(at91_shdwc_of_match, pdev->dev.of_node);
 	at91_shdwc->rcfg = match->data;