[1/1] tty: serial: sifive: Remove redundant error printing in sifive_serial_probe()

Message ID 20210511095413.4938-1-thunder.leizhen@huawei.com
State New
Headers show
Series
  • [1/1] tty: serial: sifive: Remove redundant error printing in sifive_serial_probe()
Related show

Commit Message

Zhen Lei May 11, 2021, 9:54 a.m.
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

---
 drivers/tty/serial/sifive.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

-- 
2.26.0.106.g9fadedd

Patch

diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c
index 0ac0371f943b688..4b28b5ae72899cf 100644
--- a/drivers/tty/serial/sifive.c
+++ b/drivers/tty/serial/sifive.c
@@ -947,10 +947,8 @@  static int sifive_serial_probe(struct platform_device *pdev)
 
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	base = devm_ioremap_resource(&pdev->dev, mem);
-	if (IS_ERR(base)) {
-		dev_err(&pdev->dev, "could not acquire device memory\n");
+	if (IS_ERR(base))
 		return PTR_ERR(base);
-	}
 
 	clk = devm_clk_get(&pdev->dev, NULL);
 	if (IS_ERR(clk)) {