| Message ID | 20210511100001.5047-1-thunder.leizhen@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] drm/mediatek: Remove redundant error printing in mtk_dsi_probe() | expand |
Hi everybody, Please ignore this patch and other "drm/mediatek". Looks like it would be better to combine them into a single patch. On 2021/5/11 18:00, Zhen Lei wrote: > When devm_ioremap_resource() fails, a clear enough error message will be > printed by its subfunction __devm_ioremap_resource(). The error > information contains the device name, failure cause, and possibly resource > information. > > Therefore, remove the error printing here to simplify code and reduce the > binary size. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index ae403c67cbd922d..89e351dfab88177 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1062,7 +1062,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) > dsi->regs = devm_ioremap_resource(dev, regs); > if (IS_ERR(dsi->regs)) { > ret = PTR_ERR(dsi->regs); > - dev_err(dev, "Failed to ioremap memory: %d\n", ret); > goto err_unregister_host; > } > >
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd922d..89e351dfab88177 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -1062,7 +1062,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) dsi->regs = devm_ioremap_resource(dev, regs); if (IS_ERR(dsi->regs)) { ret = PTR_ERR(dsi->regs); - dev_err(dev, "Failed to ioremap memory: %d\n", ret); goto err_unregister_host; }
When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 1 - 1 file changed, 1 deletion(-) -- 2.26.0.106.g9fadedd