| Message ID | 20210511105721.258754-1-ilias.apalodimas@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] efi_loader: Fix Kconfig for EFI_TCG2 protocol | expand |
On 5/11/21 12:57 PM, Ilias Apalodimas wrote: > EFI_TCG2 depends not only on TPMv2 but also on the underlying algorithms. > So select the missing SHA1, SHA256, SHA384 and SHA512 we currently support > > Reported-by: Michal Simek <michal.simek@xilinx.com> > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > --- > Changes since v1: > - use 'select' instead of 'depends' > lib/efi_loader/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > index 0b99d7c7749b..660236c1fc20 100644 > --- a/lib/efi_loader/Kconfig > +++ b/lib/efi_loader/Kconfig > @@ -301,6 +301,7 @@ config EFI_RNG_PROTOCOL > config EFI_TCG2_PROTOCOL > bool "EFI_TCG2_PROTOCOL support" > depends on TPM_V2 > + select on SHA1 && SHA256 && SHA384 && SHA512 it should be just select. M > help > Provide a EFI_TCG2_PROTOCOL implementation using the TPM hardware > of the platform. >
doh yea, forgot to delete the 'on' from depends. Let me send a v3 On Tue, 11 May 2021 at 14:03, Michal Simek <michal.simek@xilinx.com> wrote: > > > > On 5/11/21 12:57 PM, Ilias Apalodimas wrote: > > EFI_TCG2 depends not only on TPMv2 but also on the underlying algorithms. > > So select the missing SHA1, SHA256, SHA384 and SHA512 we currently support > > > > Reported-by: Michal Simek <michal.simek@xilinx.com> > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > > --- > > Changes since v1: > > - use 'select' instead of 'depends' > > lib/efi_loader/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > > index 0b99d7c7749b..660236c1fc20 100644 > > --- a/lib/efi_loader/Kconfig > > +++ b/lib/efi_loader/Kconfig > > @@ -301,6 +301,7 @@ config EFI_RNG_PROTOCOL > > config EFI_TCG2_PROTOCOL > > bool "EFI_TCG2_PROTOCOL support" > > depends on TPM_V2 > > + select on SHA1 && SHA256 && SHA384 && SHA512 > > it should be just select. > > M > > > help > > Provide a EFI_TCG2_PROTOCOL implementation using the TPM hardware > > of the platform. > >
diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index 0b99d7c7749b..660236c1fc20 100644 --- a/lib/efi_loader/Kconfig +++ b/lib/efi_loader/Kconfig @@ -301,6 +301,7 @@ config EFI_RNG_PROTOCOL config EFI_TCG2_PROTOCOL bool "EFI_TCG2_PROTOCOL support" depends on TPM_V2 + select on SHA1 && SHA256 && SHA384 && SHA512 help Provide a EFI_TCG2_PROTOCOL implementation using the TPM hardware of the platform.
EFI_TCG2 depends not only on TPMv2 but also on the underlying algorithms. So select the missing SHA1, SHA256, SHA384 and SHA512 we currently support Reported-by: Michal Simek <michal.simek@xilinx.com> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> --- Changes since v1: - use 'select' instead of 'depends' lib/efi_loader/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.31.0