[1/5] ASoC: cs53l30: Add missing regmap use_single config

Message ID 20210511175718.15416-1-ckeepax@opensource.cirrus.com
State Accepted
Commit 96f685974609d4c315669ef33d55dbc43996491e
Headers show
Series
  • [1/5] ASoC: cs53l30: Add missing regmap use_single config
Related show

Commit Message

Charles Keepax May 11, 2021, 5:57 p.m.
This device requires single register transactions, this will
definely cause problems with the new device ID parsing which
uses regmap_bulk_read but might also show up in the cache sync
sometimes. Add the missing flags to the regmap_config.

Fixes: 4fc81bc88ad9 ("ASoC: cs53l30: Minor error paths fixups")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
 sound/soc/codecs/cs53l30.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mark Brown May 11, 2021, 6:21 p.m. | #1
On Tue, 11 May 2021 18:57:14 +0100, Charles Keepax wrote:
> This device requires single register transactions, this will
> definely cause problems with the new device ID parsing which
> uses regmap_bulk_read but might also show up in the cache sync
> sometimes. Add the missing flags to the regmap_config.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/5] ASoC: cs53l30: Add missing regmap use_single config
      (no commit info)
[2/5] ASoC: cs42l73: Add missing regmap use_single config
      (no commit info)
[3/5] ASoC: cs35l34: Add missing regmap use_single config
      (no commit info)
[4/5] ASoC: cs35l32: Add missing regmap use_single config
      (no commit info)
[5/5] ASoC: cs42l52: Minor tidy up of error paths
      commit: 4ac9b48adf4d561d0e33419d548278f205dd70b5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Patch

diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index bd33dd048c7ce..f2087bd38dbc8 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -913,6 +913,9 @@  static struct regmap_config cs53l30_regmap = {
 	.writeable_reg = cs53l30_writeable_register,
 	.readable_reg = cs53l30_readable_register,
 	.cache_type = REGCACHE_RBTREE,
+
+	.use_single_read = true,
+	.use_single_write = true,
 };
 
 static int cs53l30_i2c_probe(struct i2c_client *client,