[-next] cpufreq: cppc: Remove unnecessary INIT_LIST_HEAD()

Message ID 20210511114703.3790524-1-yangyingliang@huawei.com
State New
Headers show
Series
  • [-next] cpufreq: cppc: Remove unnecessary INIT_LIST_HEAD()
Related show

Commit Message

Yang Yingliang May 11, 2021, 11:47 a.m.
The list_head cpu_data_list is initialized statically.
It is unnecessary to initialize by INIT_LIST_HEAD().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/cpufreq/cppc_cpufreq.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Viresh Kumar May 12, 2021, 5:36 a.m. | #1
On 11-05-21, 19:47, Yang Yingliang wrote:
> The list_head cpu_data_list is initialized statically.

> It is unnecessary to initialize by INIT_LIST_HEAD().

> 

> Reported-by: Hulk Robot <hulkci@huawei.com>

> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

> ---

>  drivers/cpufreq/cppc_cpufreq.c | 2 --

>  1 file changed, 2 deletions(-)

> 

> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c

> index 3848b4c222e1..b312fa210a39 100644

> --- a/drivers/cpufreq/cppc_cpufreq.c

> +++ b/drivers/cpufreq/cppc_cpufreq.c

> @@ -723,8 +723,6 @@ static int __init cppc_cpufreq_init(void)

>  	if ((acpi_disabled) || !acpi_cpc_valid())

>  		return -ENODEV;

>  

> -	INIT_LIST_HEAD(&cpu_data_list);

> -

>  	cppc_check_hisi_workaround();

>  

>  	ret = cpufreq_register_driver(&cppc_cpufreq_driver);


Acked-by: Viresh Kumar <viresh.kumar@linaro.org>


-- 
viresh

Patch

diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
index 3848b4c222e1..b312fa210a39 100644
--- a/drivers/cpufreq/cppc_cpufreq.c
+++ b/drivers/cpufreq/cppc_cpufreq.c
@@ -723,8 +723,6 @@  static int __init cppc_cpufreq_init(void)
 	if ((acpi_disabled) || !acpi_cpc_valid())
 		return -ENODEV;
 
-	INIT_LIST_HEAD(&cpu_data_list);
-
 	cppc_check_hisi_workaround();
 
 	ret = cpufreq_register_driver(&cppc_cpufreq_driver);