[v1,4/7] dt-bindings: devfreq: tegra30-actmon: Add cooling-cells

Message ID 20210510211008.30300-5-digetx@gmail.com
State Superseded
Headers show
Series
  • Add thermal cooling support to NVIDIA Tegra devfreq
Related show

Commit Message

Dmitry Osipenko May 10, 2021, 9:10 p.m.
The ACTMON watches activity of memory clients. Decisions about a minimum
required frequency are made based on the info from ACTMON. We can use
ACTMON as a thermal cooling device by limiting the required frequency.
Document new cooling-cells property of NVIDIA Tegra ACTMON hardware unit.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 .../devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml   | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring May 17, 2021, 9:34 p.m. | #1
On Tue, 11 May 2021 00:10:05 +0300, Dmitry Osipenko wrote:
> The ACTMON watches activity of memory clients. Decisions about a minimum

> required frequency are made based on the info from ACTMON. We can use

> ACTMON as a thermal cooling device by limiting the required frequency.

> Document new cooling-cells property of NVIDIA Tegra ACTMON hardware unit.

> 

> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>

> ---

>  .../devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml   | 5 +++++

>  1 file changed, 5 insertions(+)

> 


Reviewed-by: Rob Herring <robh@kernel.org>
Chanwoo Choi May 20, 2021, 2:49 a.m. | #2
On 5/11/21 6:10 AM, Dmitry Osipenko wrote:
> The ACTMON watches activity of memory clients. Decisions about a minimum
> required frequency are made based on the info from ACTMON. We can use
> ACTMON as a thermal cooling device by limiting the required frequency.
> Document new cooling-cells property of NVIDIA Tegra ACTMON hardware unit.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  .../devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml   | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml
> index 2a940d5d7ab4..0aa9459b7751 100644
> --- a/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml
> +++ b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml
> @@ -63,6 +63,9 @@ properties:
>        Should contain freqs and voltages and opp-supported-hw property, which
>        is a bitfield indicating SoC speedo ID mask.
>  
> +  "#cooling-cells":
> +    const: 2
> +
>  required:
>    - compatible
>    - reg
> @@ -74,6 +77,7 @@ required:
>    - interconnects
>    - interconnect-names
>    - operating-points-v2
> +  - "#cooling-cells"
>  
>  additionalProperties: false
>  
> @@ -118,4 +122,5 @@ examples:
>          operating-points-v2 = <&dvfs_opp_table>;
>          interconnects = <&mc TEGRA30_MC_MPCORER &emc>;
>          interconnect-names = "cpu-read";
> +        #cooling-cells = <2>;
>      };
> 

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Thierry Reding May 31, 2021, 9:37 a.m. | #3
On Tue, May 11, 2021 at 12:10:05AM +0300, Dmitry Osipenko wrote:
> The ACTMON watches activity of memory clients. Decisions about a minimum
> required frequency are made based on the info from ACTMON. We can use
> ACTMON as a thermal cooling device by limiting the required frequency.
> Document new cooling-cells property of NVIDIA Tegra ACTMON hardware unit.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  .../devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml   | 5 +++++
>  1 file changed, 5 insertions(+)

Acked-by: Thierry Reding <treding@nvidia.com>

Patch

diff --git a/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml
index 2a940d5d7ab4..0aa9459b7751 100644
--- a/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml
+++ b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml
@@ -63,6 +63,9 @@  properties:
       Should contain freqs and voltages and opp-supported-hw property, which
       is a bitfield indicating SoC speedo ID mask.
 
+  "#cooling-cells":
+    const: 2
+
 required:
   - compatible
   - reg
@@ -74,6 +77,7 @@  required:
   - interconnects
   - interconnect-names
   - operating-points-v2
+  - "#cooling-cells"
 
 additionalProperties: false
 
@@ -118,4 +122,5 @@  examples:
         operating-points-v2 = <&dvfs_opp_table>;
         interconnects = <&mc TEGRA30_MC_MPCORER &emc>;
         interconnect-names = "cpu-read";
+        #cooling-cells = <2>;
     };