| Message ID | 20210510150413.59356-2-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1,1/4] lib/vsprintf: Allow to override date and time separator | expand |
Hi, On Mon, May 10, 2021 at 8:04 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Use %ptTs instead of open-coded variant to print contents > of time64_t type in human readable form. > > Cc: Jason Wessel <jason.wessel@windriver.com> > Cc: Daniel Thompson <daniel.thompson@linaro.org> > Cc: kgdb-bugreport@lists.sourceforge.net > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > kernel/debug/kdb/kdb_main.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) I kinda doubt anyone would really care if we just switched kdb to just the old "%ptT". Probably no machines are parsing this string. ...but in any case, now that the nifty new format is there we might as well use it. Thus: Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Mon, May 10, 2021 at 05:05:46PM -0700, Doug Anderson wrote: > On Mon, May 10, 2021 at 8:04 AM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > Use %ptTs instead of open-coded variant to print contents > > of time64_t type in human readable form. > > > > Cc: Jason Wessel <jason.wessel@windriver.com> > > Cc: Daniel Thompson <daniel.thompson@linaro.org> > > Cc: kgdb-bugreport@lists.sourceforge.net > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > kernel/debug/kdb/kdb_main.c | 9 +-------- > > 1 file changed, 1 insertion(+), 8 deletions(-) > > I kinda doubt anyone would really care if we just switched kdb to just > the old "%ptT". Probably no machines are parsing this string. Formally it's an ABI. > ...but in any case, now that the nifty new format is there we might as > well use it. Thus: > > Reviewed-by: Douglas Anderson <dianders@chromium.org> Thanks!
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 1baa96a2ecb8..622410c45da1 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -2488,7 +2488,6 @@ static void kdb_sysinfo(struct sysinfo *val) static int kdb_summary(int argc, const char **argv) { time64_t now; - struct tm tm; struct sysinfo val; if (argc) @@ -2502,13 +2501,7 @@ static int kdb_summary(int argc, const char **argv) kdb_printf("domainname %s\n", init_uts_ns.name.domainname); now = __ktime_get_real_seconds(); - time64_to_tm(now, 0, &tm); - kdb_printf("date %04ld-%02d-%02d %02d:%02d:%02d " - "tz_minuteswest %d\n", - 1900+tm.tm_year, tm.tm_mon+1, tm.tm_mday, - tm.tm_hour, tm.tm_min, tm.tm_sec, - sys_tz.tz_minuteswest); - + kdb_printf("date %ptTs tz_minuteswest %d\n", &now, sys_tz.tz_minuteswest); kdb_sysinfo(&val); kdb_printf("uptime "); if (val.uptime > (24*60*60)) {
Use %ptTs instead of open-coded variant to print contents of time64_t type in human readable form. Cc: Jason Wessel <jason.wessel@windriver.com> Cc: Daniel Thompson <daniel.thompson@linaro.org> Cc: kgdb-bugreport@lists.sourceforge.net Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- kernel/debug/kdb/kdb_main.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)