serial: 8250_dw: Add device HID for new AMD UART controller

Message ID 20210512210413.1982933-1-luzmaximilian@gmail.com
State Accepted
Commit 3c35d2a960c0077a4cb09bf4989f45d289332ea0
Headers show
Series
  • serial: 8250_dw: Add device HID for new AMD UART controller
Related show

Commit Message

Maximilian Luz May 12, 2021, 9:04 p.m.
Add device HID AMDI0022 to the AMD UART controller driver match table
and create a platform device for it. This controller can be found on
Microsoft Surface Laptop 4 devices and seems similar enough that we can
just copy the existing AMDI0020 entries.

Cc: <stable@vger.kernel.org> # 5.10+
Tested-by: Sachi King <nakato@nakato.io>
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
---
 drivers/acpi/acpi_apd.c           | 1 +
 drivers/tty/serial/8250/8250_dw.c | 1 +
 2 files changed, 2 insertions(+)

Comments

Andy Shevchenko May 13, 2021, 7:08 a.m. | #1
On Thu, May 13, 2021 at 1:20 AM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>

> Add device HID AMDI0022 to the AMD UART controller driver match table

> and create a platform device for it. This controller can be found on

> Microsoft Surface Laptop 4 devices and seems similar enough that we can

> just copy the existing AMDI0020 entries.


Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> # for 8250_dw part


> Cc: <stable@vger.kernel.org> # 5.10+

> Tested-by: Sachi King <nakato@nakato.io>

> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>

> ---

>  drivers/acpi/acpi_apd.c           | 1 +

>  drivers/tty/serial/8250/8250_dw.c | 1 +

>  2 files changed, 2 insertions(+)

>

> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c

> index 0ec5b3f69112..6e02448d15d9 100644

> --- a/drivers/acpi/acpi_apd.c

> +++ b/drivers/acpi/acpi_apd.c

> @@ -226,6 +226,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {

>         { "AMDI0010", APD_ADDR(wt_i2c_desc) },

>         { "AMD0020", APD_ADDR(cz_uart_desc) },

>         { "AMDI0020", APD_ADDR(cz_uart_desc) },

> +       { "AMDI0022", APD_ADDR(cz_uart_desc) },

>         { "AMD0030", },

>         { "AMD0040", APD_ADDR(fch_misc_desc)},

>         { "HYGO0010", APD_ADDR(wt_i2c_desc) },

> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c

> index 9e204f9b799a..a3a0154da567 100644

> --- a/drivers/tty/serial/8250/8250_dw.c

> +++ b/drivers/tty/serial/8250/8250_dw.c

> @@ -714,6 +714,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {

>         { "APMC0D08", 0},

>         { "AMD0020", 0 },

>         { "AMDI0020", 0 },

> +       { "AMDI0022", 0 },

>         { "BRCM2032", 0 },

>         { "HISI0031", 0 },

>         { },

> --

> 2.31.1

>



-- 
With Best Regards,
Andy Shevchenko
Greg KH May 17, 2021, 3:57 p.m. | #2
On Mon, May 17, 2021 at 05:01:15PM +0200, Rafael J. Wysocki wrote:
> On Thu, May 13, 2021 at 12:25 AM Maximilian Luz <luzmaximilian@gmail.com> wrote:
> >
> > Add device HID AMDI0022 to the AMD UART controller driver match table
> > and create a platform device for it. This controller can be found on
> > Microsoft Surface Laptop 4 devices and seems similar enough that we can
> > just copy the existing AMDI0020 entries.
> >
> > Cc: <stable@vger.kernel.org> # 5.10+
> > Tested-by: Sachi King <nakato@nakato.io>
> > Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> or please let me know if this needs to go in through ACPI (I'm
> assuming that it doesn't).

I've already taken it in my tty tree :)

thanks,

greg k-h

Patch

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 0ec5b3f69112..6e02448d15d9 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -226,6 +226,7 @@  static const struct acpi_device_id acpi_apd_device_ids[] = {
 	{ "AMDI0010", APD_ADDR(wt_i2c_desc) },
 	{ "AMD0020", APD_ADDR(cz_uart_desc) },
 	{ "AMDI0020", APD_ADDR(cz_uart_desc) },
+	{ "AMDI0022", APD_ADDR(cz_uart_desc) },
 	{ "AMD0030", },
 	{ "AMD0040", APD_ADDR(fch_misc_desc)},
 	{ "HYGO0010", APD_ADDR(wt_i2c_desc) },
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 9e204f9b799a..a3a0154da567 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -714,6 +714,7 @@  static const struct acpi_device_id dw8250_acpi_match[] = {
 	{ "APMC0D08", 0},
 	{ "AMD0020", 0 },
 	{ "AMDI0020", 0 },
+	{ "AMDI0022", 0 },
 	{ "BRCM2032", 0 },
 	{ "HISI0031", 0 },
 	{ },