| Message ID | 1620801369-18642-1-git-send-email-zou_wei@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] USB: EHCI: ehci-mv: add missing MODULE_DEVICE_TABLE | expand |
On Wed, May 12, 2021 at 02:36:09PM +0800, Zou Wei wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/usb/host/ehci-mv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c > index cffdc8d..beb478c 100644 > --- a/drivers/usb/host/ehci-mv.c > +++ b/drivers/usb/host/ehci-mv.c > @@ -266,6 +266,7 @@ static const struct platform_device_id ehci_id_table[] = { > {"pxa-sph", 0}, > {}, > }; > +MODULE_DEVICE_TABLE(platform, ehci_id_table); > > static void mv_ehci_shutdown(struct platform_device *pdev) > { This is a bit odd. Nothing wrong with it, of course, but it leads one to wonder how the driver ever worked. Maybe the platforms that can use it never build the driver as a loadable module. Acked-by: Alan Stern <stern@rowland.harvard.edu> Alan Stern
On Wed, May 12, 2021 at 02:36:09PM +0800, Zou Wei wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/usb/host/ehci-mv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c > index cffdc8d..beb478c 100644 > --- a/drivers/usb/host/ehci-mv.c > +++ b/drivers/usb/host/ehci-mv.c > @@ -266,6 +266,7 @@ static const struct platform_device_id ehci_id_table[] = { > {"pxa-sph", 0}, > {}, > }; > +MODULE_DEVICE_TABLE(platform, ehci_id_table); As I said elsewhere, I'm not taking these unless you can show a reason why they are needed. thanks, greg k-h
diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index cffdc8d..beb478c 100644 --- a/drivers/usb/host/ehci-mv.c +++ b/drivers/usb/host/ehci-mv.c @@ -266,6 +266,7 @@ static const struct platform_device_id ehci_id_table[] = { {"pxa-sph", 0}, {}, }; +MODULE_DEVICE_TABLE(platform, ehci_id_table); static void mv_ehci_shutdown(struct platform_device *pdev) {
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/usb/host/ehci-mv.c | 1 + 1 file changed, 1 insertion(+)