ACPI: APEI: Don't warn if ACPI is disabled

Message ID 20210514153414.847902-1-jonathanh@nvidia.com
State New
Headers show
Series
  • ACPI: APEI: Don't warn if ACPI is disabled
Related show

Commit Message

Jon Hunter May 14, 2021, 3:34 p.m.
If ACPI is not enabled but support for ACPI and APEI is enabled in the
kernel, then the following warning is seen on boot ...

 WARNING KERN EINJ: ACPI disabled.

For ARM64 platforms, the 'acpi_disabled' variable is true by default
and hence, the above is often seen on ARM64. Given that it can be
normal for ACPI to be disabled, make this an informational print rather
that a warning.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
Please note that the motivation for this change is to filter out
any warnings that might not be actual issues. We have some automated
tests that we run to catch warnings and errors and although we could
add this to a list of non critical warnings, it is preferred to make
this an informational print.

 drivers/acpi/apei/einj.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rafael J. Wysocki May 21, 2021, 5:01 p.m. | #1
On Fri, May 14, 2021 at 5:34 PM Jon Hunter <jonathanh@nvidia.com> wrote:
>

> If ACPI is not enabled but support for ACPI and APEI is enabled in the

> kernel, then the following warning is seen on boot ...

>

>  WARNING KERN EINJ: ACPI disabled.

>

> For ARM64 platforms, the 'acpi_disabled' variable is true by default

> and hence, the above is often seen on ARM64. Given that it can be

> normal for ACPI to be disabled, make this an informational print rather

> that a warning.

>

> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>

> ---

> Please note that the motivation for this change is to filter out

> any warnings that might not be actual issues. We have some automated

> tests that we run to catch warnings and errors and although we could

> add this to a list of non critical warnings, it is preferred to make

> this an informational print.

>

>  drivers/acpi/apei/einj.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c

> index 328e8aeece6c..2882450c443e 100644

> --- a/drivers/acpi/apei/einj.c

> +++ b/drivers/acpi/apei/einj.c

> @@ -673,7 +673,7 @@ static int __init einj_init(void)

>         struct apei_exec_context ctx;

>

>         if (acpi_disabled) {

> -               pr_warn("ACPI disabled.\n");

> +               pr_info("ACPI disabled.\n");

>                 return -ENODEV;

>         }

>

> --


Applied as 5.14 material, thanks!

Patch

diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
index 328e8aeece6c..2882450c443e 100644
--- a/drivers/acpi/apei/einj.c
+++ b/drivers/acpi/apei/einj.c
@@ -673,7 +673,7 @@  static int __init einj_init(void)
 	struct apei_exec_context ctx;
 
 	if (acpi_disabled) {
-		pr_warn("ACPI disabled.\n");
+		pr_info("ACPI disabled.\n");
 		return -ENODEV;
 	}