[1/1] ssb: Fix error return code in ssb_bus_scan()

Message ID 20210515072949.7151-1-thunder.leizhen@huawei.com
State New
Headers show
Series
  • [1/1] ssb: Fix error return code in ssb_bus_scan()
Related show

Commit Message

Leizhen (ThunderTown) May 15, 2021, 7:29 a.m.
Fix to return -EINVAL from the error handling case instead of 0, as done
elsewhere in this function.

Fixes: 61e115a56d1a ("[SSB]: add Sonics Silicon Backplane bus support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

---
 drivers/ssb/scan.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.26.0.106.g9fadedd

Comments

Michael Büsch May 15, 2021, 2:52 p.m. | #1
On Sat, 15 May 2021 15:29:49 +0800
Zhen Lei <thunder.leizhen@huawei.com> wrote:

> Fix to return -EINVAL from the error handling case instead of 0, as done

> elsewhere in this function.


> @@ -325,6 +325,7 @@ int ssb_bus_scan(struct ssb_bus *bus,

>  	if (bus->nr_devices > ARRAY_SIZE(bus->devices)) {

>  		pr_err("More than %d ssb cores found (%d)\n",

>  		       SSB_MAX_NR_CORES, bus->nr_devices);

> +		err = -EINVAL;

>  		goto err_unmap;

>  	}

>  	if (bus->bustype == SSB_BUSTYPE_SSB) {



Acked-by: Michael Büsch <m@bues.ch>


-- 
Michael
Kalle Valo June 15, 2021, 10:10 a.m. | #2
Zhen Lei <thunder.leizhen@huawei.com> wrote:

> Fix to return -EINVAL from the error handling case instead of 0, as done

> elsewhere in this function.

> 

> Fixes: 61e115a56d1a ("[SSB]: add Sonics Silicon Backplane bus support")

> Reported-by: Hulk Robot <hulkci@huawei.com>

> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

> Acked-by: Michael Büsch <m@bues.ch>


Patch applied to wireless-drivers-next.git, thanks.

77a0989baa42 ssb: Fix error return code in ssb_bus_scan()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210515072949.7151-1-thunder.leizhen@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Patch

diff --git a/drivers/ssb/scan.c b/drivers/ssb/scan.c
index f49ab1aa2149ab2..4161e5d1f276e11 100644
--- a/drivers/ssb/scan.c
+++ b/drivers/ssb/scan.c
@@ -325,6 +325,7 @@  int ssb_bus_scan(struct ssb_bus *bus,
 	if (bus->nr_devices > ARRAY_SIZE(bus->devices)) {
 		pr_err("More than %d ssb cores found (%d)\n",
 		       SSB_MAX_NR_CORES, bus->nr_devices);
+		err = -EINVAL;
 		goto err_unmap;
 	}
 	if (bus->bustype == SSB_BUSTYPE_SSB) {