[RFC,01/13,net-next] bcmgenet: remove call to netdev_boot_setup_check

Message ID 20210515221320.1255291-2-arnd@kernel.org
State New
Headers show
Series
  • drivers/net/Space.c cleanup
Related show

Commit Message

Arnd Bergmann May 15, 2021, 10:13 p.m.
From: Arnd Bergmann <arnd@arndb.de>


The driver has never used the netdev->{irq,base_addr,mem_start}
members, so this call is completely unnecessary.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.29.2

Comments

Florian Fainelli May 16, 2021, 12:04 a.m. | #1
On 5/15/2021 3:13 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>

> 

> The driver has never used the netdev->{irq,base_addr,mem_start}

> members, so this call is completely unnecessary.

> 

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: Florian Fainelli <f.fainelli@gmail.com>

-- 
Florian

Patch

diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index fcca023f22e5..b52910f141dc 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -3972,8 +3972,6 @@  static int bcmgenet_probe(struct platform_device *pdev)
 	 */
 	dev->needed_headroom += 64;
 
-	netdev_boot_setup_check(dev);
-
 	priv->dev = dev;
 	priv->pdev = pdev;