Fix warning due to format mismatch for field width argument to fprintf()

Message ID 20210515064907.28235-1-heiko.thiery@gmail.com
State Superseded
Headers show
Series
  • Fix warning due to format mismatch for field width argument to fprintf()
Related show

Commit Message

Heiko Thiery May 15, 2021, 6:49 a.m.
bnxt.c:66:54: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘unsigned int’ [-Wformat=]
   66 |   fprintf(stdout, "Length is too short, expected 0x%lx\n",
      |                                                    ~~^
      |                                                      |
      |                                                      long unsigned int
      |                                                    %x

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 bnxt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Thiery May 15, 2021, 7:59 a.m. | #1
Added Ben's other mail addresses.

Am Sa., 15. Mai 2021 um 08:49 Uhr schrieb Heiko Thiery <heiko.thiery@gmail.com>:
>
> bnxt.c:66:54: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘unsigned int’ [-Wformat=]
>    66 |   fprintf(stdout, "Length is too short, expected 0x%lx\n",
>       |                                                    ~~^
>       |                                                      |
>       |                                                      long unsigned int
>       |                                                    %x
>
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
>  bnxt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bnxt.c b/bnxt.c
> index b46db72..0c62d1e 100644
> --- a/bnxt.c
> +++ b/bnxt.c
> @@ -63,7 +63,7 @@ int bnxt_dump_regs(struct ethtool_drvinfo *info __maybe_unused, struct ethtool_r
>                 return 0;
>
>         if (regs->len < (BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN)) {
> -               fprintf(stdout, "Length is too short, expected 0x%lx\n",
> +               fprintf(stdout, "Length is too short, expected 0x%x\n",
>                         BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN);
>                 return -1;
>         }
> --
> 2.20.1
>
Heiko Thiery May 16, 2021, 6:11 p.m. | #2
Hi all,

Am Sa., 15. Mai 2021 um 09:59 Uhr schrieb Heiko Thiery <heiko.thiery@gmail.com>:
>

> Added Ben's other mail addresses.

>

> Am Sa., 15. Mai 2021 um 08:49 Uhr schrieb Heiko Thiery <heiko.thiery@gmail.com>:

> >

> > bnxt.c:66:54: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘unsigned int’ [-Wformat=]

> >    66 |   fprintf(stdout, "Length is too short, expected 0x%lx\n",

> >       |                                                    ~~^

> >       |                                                      |

> >       |                                                      long unsigned int

> >       |                                                    %x

> >

> > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

> > ---

> >  bnxt.c | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/bnxt.c b/bnxt.c

> > index b46db72..0c62d1e 100644

> > --- a/bnxt.c

> > +++ b/bnxt.c

> > @@ -63,7 +63,7 @@ int bnxt_dump_regs(struct ethtool_drvinfo *info __maybe_unused, struct ethtool_r

> >                 return 0;

> >

> >         if (regs->len < (BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN)) {

> > -               fprintf(stdout, "Length is too short, expected 0x%lx\n",

> > +               fprintf(stdout, "Length is too short, expected 0x%x\n",

> >                         BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN);


This does not solve the issue. The provided patch only works on 32bit
systems. It seems there is a problem with 32bit vs 64bit.

-- 
Heiko
Ben Hutchings May 16, 2021, 8:40 p.m. | #3
On Sun, 2021-05-16 at 20:11 +0200, Heiko Thiery wrote:
> Hi all,

> 

> Am Sa., 15. Mai 2021 um 09:59 Uhr schrieb Heiko Thiery <heiko.thiery@gmail.com>:

> > 

> > Added Ben's other mail addresses.

> > 

> > Am Sa., 15. Mai 2021 um 08:49 Uhr schrieb Heiko Thiery <heiko.thiery@gmail.com>:

> > > 

> > > bnxt.c:66:54: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘unsigned int’ [-Wformat=]

> > >    66 |   fprintf(stdout, "Length is too short, expected 0x%lx\n",

> > >       |                                                    ~~^

> > >       |                                                      |

> > >       |                                                      long unsigned int

> > >       |                                                    %x

> > > 

> > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

> > > ---

> > >  bnxt.c | 2 +-

> > >  1 file changed, 1 insertion(+), 1 deletion(-)

> > > 

> > > diff --git a/bnxt.c b/bnxt.c

> > > index b46db72..0c62d1e 100644

> > > --- a/bnxt.c

> > > +++ b/bnxt.c

> > > @@ -63,7 +63,7 @@ int bnxt_dump_regs(struct ethtool_drvinfo *info __maybe_unused, struct ethtool_r

> > >                 return 0;

> > > 

> > >         if (regs->len < (BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN)) {

> > > -               fprintf(stdout, "Length is too short, expected 0x%lx\n",

> > > +               fprintf(stdout, "Length is too short, expected 0x%x\n",

> > >                         BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN);

> 

> This does not solve the issue. The provided patch only works on 32bit

> systems. It seems there is a problem with 32bit vs 64bit.


It looks like the type of BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN will
be size_t, so the correct format is "%zx".

Ben.

-- 
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.

Patch

diff --git a/bnxt.c b/bnxt.c
index b46db72..0c62d1e 100644
--- a/bnxt.c
+++ b/bnxt.c
@@ -63,7 +63,7 @@  int bnxt_dump_regs(struct ethtool_drvinfo *info __maybe_unused, struct ethtool_r
 		return 0;
 
 	if (regs->len < (BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN)) {
-		fprintf(stdout, "Length is too short, expected 0x%lx\n",
+		fprintf(stdout, "Length is too short, expected 0x%x\n",
 			BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN);
 		return -1;
 	}